Bug 12517 - Download and send list popups broken in bootstrap OPAC
Summary: Download and send list popups broken in bootstrap OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-02 13:09 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12517 - Download and send list popups broken in bootstrap OPAC (2.92 KB, patch)
2014-07-02 13:14 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12517 - Download and send list popups broken in bootstrap OPAC (2.99 KB, patch)
2014-07-02 14:19 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
[PASSED QA] Bug 12517 - Download and send list popups broken in bootstrap OPAC (3.04 KB, patch)
2014-07-03 14:21 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-02 13:09:22 UTC 
In the bootstrap OPAC the download list and send list links do not trigger the correct popups because of a JavaScript error.
Comment 1 Owen Leonard 2014-07-02 13:14:40 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-07-02 14:19:23 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2014-07-03 14:21:16 UTC 
Created attachment 29481 [details] [review]
[PASSED QA] Bug 12517 - Download and send list popups broken in bootstrap OPAC

A JavaScript error prevents the download list and send list links in the
bootstrap OPAC from functioning correctly. A variable declaration was
removed from basket.js during the creation of the theme but
opac-shelves.tt was not changed accordingly. This patch corrects it.

To test, view an existing shelf in the bootstrap OPAC and test the
"download list" and "send list" links. They should each trigger popups
without any errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Popups pops again, no koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2014-07-14 12:02:11 UTC 
Patch pushed to master.

Thanks Owen!