Was having a talk with one of our designers here, she had a concern about the div-happiness of the advanced search page. I had a look, and tend to agree with her - without so many container-fluids, and putting everything in the main div, the page is easier to style. The extra container-fluid divs seem superfluous - they don't have extra classes on them for targeting with CSS. The page is broken up in a rather strange way - while talking with her I realised that I had simply gotten used to the way it looks, and hadn't given it any thought at all that it could be different or better. The attached patch I have run past her, and she finds it more pleasing to style than the old structure. The patch doesn't change any functionality - only layout. I'd especially like to hear from Owen on this, please. :) Liz
Created attachment 29461 [details] [review] Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid.
Created attachment 30149 [details] [review] [Signed-off] Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid. Patch behaves as expected. Advanced search looks much better now. Signed-off-by: Marc Véron <veron@veron.ch>
Hello Has anybody ran a UX survey on this page? I have always thought this page was rather unfriendly for average users, but no real proof of that. Mathieu Saby
Not that I am aware of. Generally, a UX survey of the OPAC would be a good thing to do. Liz
Created attachment 30823 [details] [review] [PASSED QA] Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid. Patch behaves as expected. Advanced search looks much better now. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked visually and with HTML validator.
Patch pushed to master. Thanks Liz!