The new ajax patron search needs to add newly created patron lists to the pulldown dynamically since the page is no longer reloaded. In addition, the notice should fade out after a given amount of time so another addition of patrons to a list is more prominent.
It also appears that existing patron lists don't always show in the pulldown. Increasing severity.
Created attachment 41007 [details] [review] Bug 12525: FIX patron lists dropdown is empty On the patrons home page, the dropdown list is not populated. Test plan: 1/ Go on the patrons home page (members/members-home.pl) 2/ Launch a search 3/ The dropdown list close to "Add selected patrons to" should contain all your patron lists
Created attachment 41008 [details] [review] Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created
Created attachment 41084 [details] [review] Bug 12525: FIX patron lists dropdown is empty On the patrons home page, the dropdown list is not populated. Test plan: 1/ Go on the patrons home page (members/members-home.pl) 2/ Launch a search 3/ The dropdown list close to "Add selected patrons to" should contain all your patron lists NOTE: Initially tested with both which created lists. git reset --hard origin/master And then dropdown list was missing them. Applied just this one, and they were listed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 41085 [details] [review] Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created NOTE: And the single list doesn't duplicate patrons that were saved both times. Both patches needed to make the list functionality work more sanely. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
There is something going wrong here: 1) Go to patron search home page 2) Launch a search (I used "d") 3) Check one patron, say [New list] from pull down 4) Name the list, hit the save button behind it 5) Check another patron, pull down list still shows newly created list - hit save again 6) Another list with the same name is added It will always create a new list - even if you switch the pull down to another preexisting list.
Hm interesting: It doesn't really add a new list, but it adds another entry to the drop down every time you hit 'save'. Once you reload the page the double ups in the pull down are gone.
Created attachment 42193 [details] [review] Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created
Katrin, thanks for the catch! Weird, I was sure I had tested this one correctly.
I cannot even test this because in the latest master it doesn't show any lists which I have created. But if I click the button "Patron lists" there it shows the lists I have created.
(In reply to Joonas Kylmälä from comment #10) > I cannot even test this because in the latest master it doesn't show any > lists which I have created. But if I click the button "Patron lists" there > it shows the lists I have created. This is fixed by the first patch.
Created attachment 42257 [details] [review] Bug 12525: FIX patron lists dropdown is empty On the patrons home page, the dropdown list is not populated. Test plan: 1/ Go on the patrons home page (members/members-home.pl) 2/ Launch a search 3/ The dropdown list close to "Add selected patrons to" should contain all your patron lists NOTE: Initially tested with both which created lists. git reset --hard origin/master And then dropdown list was missing them. Applied just this one, and they were listed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 42258 [details] [review] Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 42370 [details] [review] [PASSED QA] Bug 12525: FIX patron lists dropdown is empty On the patrons home page, the dropdown list is not populated. Test plan: 1/ Go on the patrons home page (members/members-home.pl) 2/ Launch a search 3/ The dropdown list close to "Add selected patrons to" should contain all your patron lists NOTE: Initially tested with both which created lists. git reset --hard origin/master And then dropdown list was missing them. Applied just this one, and they were listed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 42371 [details] [review] [PASSED QA] Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!
Pushed to 3.20.x will be in 3.20.4
Pushed to 3.18 will be in 3.18.11