Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac
Summary: PROG/CCSR deprecation: Make getlanguages() theme independent for opac
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 11346
  Show dependency treegraph
 
Reported: 2014-07-07 00:01 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac (1.85 KB, patch)
2014-07-07 00:19 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac (1.88 KB, patch)
2014-07-07 17:24 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac (1.93 KB, patch)
2014-07-10 14:21 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[PASSED QA] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac (2.00 KB, patch)
2014-07-11 13:34 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-07-07 00:01:04 UTC
getlanguages() function on C4/Languages.pm has a hardcoded reference to 'prog'
Comment 1 Bernardo Gonzalez Kriegel 2014-07-07 00:19:07 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-07-07 17:24:46 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2014-07-10 14:21:44 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-07-11 13:34:03 UTC
Created attachment 29641 [details] [review]
[PASSED QA] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac

This patch removes a reference to prog theme on getlanguages()
when ENV var HTTP_ACCEPT_LANGUAGE is checked.

Changed to use sysprefs to find theme for opac and intranet

To test:
1) Apply the patch
2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc
3) Enable those languages for OPAC on I18N prefs
4) Using Firefox, clean all history/cookies
5) Change variable intl.accept_languages (will do several times)
 a) got to about:config
 b) search 'lang'
 c) look for the variable, double click, change to 'de-DE'
6) Go to opac page, must load in german
7) Repeat for each translated lang: clean > change val > reload opac
   On each case opac must load on configured language
8) Just to test, set variable on untranslated lang, opac page
must load on first value of list of enabled languages
9) prove t/Languages.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2014-07-14 12:01:46 UTC
Patch pushed to master.

Thanks Bernardo!