Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent
Summary: PROG/CCSR Deprecation: Make opac translation theme independent
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 11346
  Show dependency treegraph
 
Reported: 2014-07-07 03:37 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent (4.32 KB, patch)
2014-07-07 03:40 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent (4.38 KB, patch)
2014-07-25 11:33 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent (4.48 KB, patch)
2014-08-03 14:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-07-07 03:37:32 UTC
Translation scripts have 'prog' hardcoded for OPAC
Comment 1 Bernardo Gonzalez Kriegel 2014-07-07 03:40:43 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-07-25 11:33:08 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-03 14:42:48 UTC
Created attachment 30517 [details] [review]
[PASSED QA] Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent

This patch makes opac translation files theme independent
A side effect is that current prog translation file is
renamed.

But the renaming is not added, that gives a patch of ~60M!

Current list of languages are now obtained from pref files.

To test:
1) Apply the patch

2) For your preferred language, rename opac prog file
from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po'

3) Update that language, there must be no errors
cd misc/translation
./translate update xx-YY [-v]
Check updated po files

4) Install any language, there must be no errors
./translate install xx-YY
Check prog theme for that language

5) Create translation files. Remove a language or create new lang files
./translate create zz-WW
ls -l po/zz-WW*po
check there are 3 files (and *~) for opac

6) Check updated pod for LangInstaler.pm and translate script

When PROG/CCSR themes are removed, I'll add a Bug to remove
corresponding files.

Perhaps RM could add a followup to rename all files,
cd misc/translator/po
for old in $(ls *opac-t*); do
    new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/');
    git mv $old $new;
done

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Comment 4 Chris Cormack 2014-08-16 01:50:50 UTC
Pushed to MM-OPAC/theme_dep
Comment 5 Tomás Cohen Arazi 2014-10-30 01:01:52 UTC
Patch merged into master.

Thanks Bernardo!