Paola found the following error on testing bug 11395 comment 33: ERROR on MARC modification templates: unavailable "Every" option: I've edited this action: Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / Then I've changed all the 650-s into 750-s. I see "All" becoming "Every" (I have not understood why it has happened). I've saved, and I've editing the action again: now "All" is shown. I've not been able to set "Every" option. I think that showing "Every" is an error, or there's a lack in managing that option (see C) below).
Removing the dependency for now. There is still no code here.
Created attachment 42767 [details] [review] Bug 12540: Display "Every" on editing a MMT action if previously selected On creating a marc modification template action, the "All" is changed with "Every" if the condition field is the same as the original field. But on editing, the "All" value is not replaced. For consistency, it should. Test plan: 1/ Create the following action: Copy field 650$x to 650$y if 650$z matches "foobar" Note that the "All" is replaced with "Every" when the condition is the same field as the original field. 2/ Save 3/ Edit the action. The "Every" should be selected. Without this patch, "All" is selected.
I'm ok with the patch. Now i have "every" if i had "every" before saving. But what is the point of changing this choice ? Especially as we change only the label, not the value of the option. So it would not change anything in the modification process ?
It's just a wording improvement.
Created attachment 44200 [details] [review] [SIGNED-OFF] Bug 12540: Display "Every" on editing a MMT action if previously selected On creating a marc modification template action, the "All" is changed with "Every" if the condition field is the same as the original field. But on editing, the "All" value is not replaced. For consistency, it should. Test plan: 1/ Create the following action: Copy field 650$x to 650$y if 650$z matches "foobar" Note that the "All" is replaced with "Every" when the condition is the same field as the original field. 2/ Save 3/ Edit the action. The "Every" should be selected. Without this patch, "All" is selected. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Created attachment 44580 [details] [review] [PASSED QA] Bug 12540: Display "Every" on editing a MMT action if previously selected On creating a marc modification template action, the "All" is changed with "Every" if the condition field is the same as the original field. But on editing, the "All" value is not replaced. For consistency, it should. Test plan: 1/ Create the following action: Copy field 650$x to 650$y if 650$z matches "foobar" Note that the "All" is replaced with "Every" when the condition is the same field as the original field. 2/ Save 3/ Edit the action. The "Every" should be selected. Without this patch, "All" is selected. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
This patch has been pushed to 3.20.x, will be in 3.20.6.
Pushed to 3.18.13, and released.