12570 – Warnings in t/Biblio.t could be tested

Bug 12570 - Warnings in t/Biblio.t could be tested

Summary: Warnings in t/Biblio.t could be tested

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Test Suite (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low trivial
Assignee:	Tomás Cohen Arazi (tcohen)
QA Contact:	Galen Charlton

URL:
Keywords:

Depends on:
Blocks:

Reported:	2014-07-14 13:01 UTC by Tomás Cohen Arazi (tcohen)
Modified:	2015-06-04 23:33 UTC (History)
CC List:	1 user (show)

See Also:
Change sponsored?:	---
Patch complexity:	Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12570: test for carped warnings in t/Biblio.t (7.31 KB, patch) 2014-07-14 13:04 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
[SIGNED-OFF] Bug 12570: test for carped warnings in t/Biblio.t (7.42 KB, patch) 2014-07-26 21:26 UTC, Bernardo Gonzalez Kriegel	Details \| Diff \| Splinter Review
[PASSED QA] Bug 12570: test for carped warnings in t/Biblio.t (7.49 KB, patch) 2014-07-27 22:39 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomás Cohen Arazi (tcohen) 2014-07-14 13:01:35 UTC

To test:
- Run prove t/Biblio.t
- Warnings printed on STDOUT

Those could be catched and its output documented in the unit tests.

Comment 1 Tomás Cohen Arazi (tcohen) 2014-07-14 13:04:07 UTC Comment hidden (obsolete)

Created attachment 29675 [details] [review]
Bug 12570: test for carped warnings in t/Biblio.t

To test:
- Run
  $ prove t/Biblio.t
=> Warnings printed to STDOUT
- Apply patch
- Run
  $ prove t/Biblio.t
=> No warnings

Comment 2 Bernardo Gonzalez Kriegel 2014-07-26 21:26:16 UTC Comment hidden (obsolete)

Created attachment 30150 [details] [review]
[SIGNED-OFF] Bug 12570: test for carped warnings in t/Biblio.t

To test:
- Run
  $ prove t/Biblio.t
=> Warnings printed to STDOUT
- Apply patch
- Run
  $ prove t/Biblio.t
=> No warnings

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No more warnings. No koha-qa errors

Comment 3 Katrin Fischer 2014-07-27 22:39:05 UTC

Created attachment 30169 [details] [review]
[PASSED QA] Bug 12570: test for carped warnings in t/Biblio.t

To test:
- Run
  $ prove t/Biblio.t
=> Warnings printed to STDOUT
- Apply patch
- Run
  $ prove t/Biblio.t
=> No warnings

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No more warnings. No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.

Comment 4 Tomás Cohen Arazi (tcohen) 2014-07-29 14:51:12 UTC

Patch pushed to master.