Bug 12576 - search links need style id
Summary: search links need style id
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Sean Hamlin
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-14 21:35 UTC by Nicole C. Engard
Modified: 2015-06-04 23:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
link color hard to read (26.40 KB, image/png)
2014-07-14 21:35 UTC, Nicole C. Engard
Details
proposed patch (86.87 KB, patch)
2014-07-25 02:55 UTC, Sean Hamlin
Details | Diff | Splinter Review
Attachment to Bug 12576 - search links need style id (86.96 KB, patch)
2014-08-02 17:03 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 12576: Make the more/fewer options and "new search" links on the advanced search page look better. (2.82 KB, patch)
2014-08-22 10:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12576: Update opac.css file (98.24 KB, patch)
2014-08-22 10:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12576: Update opac.css file (83.55 KB, patch)
2014-08-22 10:15 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-07-14 21:35:23 UTC
Created attachment 29687 [details]
link color hard to read

When on the advanced search the links next to the search box need a class or ID so that they can be styled. For example, the link color in the attached image would be better white, but there is no ID to grab on to like this is on the moresearches box at the top.
Comment 1 Sean Hamlin 2014-07-25 02:55:56 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2014-08-02 17:03:48 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens (kidclamp) 2014-08-02 17:06:27 UTC
All worked as expected and looks great
Comment 4 Jonathan Druart 2014-08-22 10:12:25 UTC
Created attachment 31071 [details] [review]
Bug 12576: Make the more/fewer options and "new search" links on the advanced search page look better.

How to test:
1/ Visit /cgi-bin/koha/opac-search.pl
2/ Assert the "More/Fewer options" buttons look like bootstrap default buttons
3/ Assert the "New search" button looks like a bootstrap default button
4/ Assert the visited colour of the buttons remains #333 (light grey)
5/ Assert the buttons still function as expected

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-08-22 10:12:29 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2014-08-22 10:15:01 UTC
Created attachment 31073 [details] [review]
Bug 12576: Update opac.css file

This file had a conflict. I prefer to put the changes in a specific
commit.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Jonathan Druart 2014-08-22 10:15:37 UTC
(In reply to Jonathan Druart from comment #5)
> Created attachment 31072 [details] [review] [review]

I forgot the --compress flag
Comment 8 Tomás Cohen Arazi (tcohen) 2014-08-22 14:14:17 UTC
Patches pushed to master.

Thanks Sean!