Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch
Summary: Control of branch displayed in search results linked to HomeOrHoldingBranch
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-16 11:08 UTC by Kyle M Hall
Modified: 2015-06-04 23:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch (5.61 KB, patch)
2014-07-16 11:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch (5.49 KB, patch)
2014-07-16 11:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch (5.54 KB, patch)
2014-07-18 14:14 UTC, Melissa Lefebvre
Details | Diff | Splinter Review
[PASSED QA] Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch (5.74 KB, patch)
2014-08-18 23:12 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-07-16 11:08:39 UTC
Some libraries would like the ability choose to display the home branch on search results while having circulation rules based on the holding branch. This is currently impossible because both the display of the branch in search results, and the selection of the home or holding branch for circulation rules are controlled by the same system preference: HomeOrHoldingBranch. This preference is described as being used only for circulation rules, and makes no mention of its use for display control. The display control should be split off into a separate preference.
Comment 1 Kyle M Hall 2014-07-16 11:47:23 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-07-16 11:52:55 UTC Comment hidden (obsolete)
Comment 3 Jason Robb 2014-07-18 14:10:03 UTC
I've tested this and it works as described.
Comment 4 Melissa Lefebvre 2014-07-18 14:14:42 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-08-18 23:12:04 UTC
Created attachment 30957 [details] [review]
[PASSED QA] Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch

Some libraries would like the ability choose to display the home branch
on search results while having circulation rules based on the holding
branch. This is currently impossible because both the display of the
branch in search results, and the selection of the home or holding
branch for circulation rules are controlled by the same system
preference: HomeOrHoldingBranch. This preference is described as being
used only for circulation rules, and makes no mention of its use for
display control. The display control should be split off into a separate
preference.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Note the value of the new system preference StaffSearchResultsDisplayBranch
   matches the current value of HomeOrHoldingBranch
4) Set the preference to home branch
5) Perform a staff catalog search with results having items with differing home and
   holding branches.
6) Note the home branch displays
7) Set the preference to holding branch
8) Repeat step 5
9) Note the holding branch displays

Signed-off-by: Jason Robb <jrobb@sekls.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, logic is now tied to a new system preference.
Passes tests and QA script.
Comment 6 Katrin Fischer 2014-08-18 23:15:03 UTC
I wonder if there is a way we could avoid another preference for this, but it works as described.
Comment 7 Tomás Cohen Arazi 2014-09-05 15:32:35 UTC
Patch pushed to master.

Thanks Kyle!