Bug 12587 - Improve output of filter information on patrons with the most checkouts report
Summary: Improve output of filter information on patrons with the most checkouts report
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/reports/bor_issues_top.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-16 15:06 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12587 - Improve output of filter information on patrons with the most checkouts report (4.69 KB, patch)
2014-07-16 15:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12587 - Improve output of filter information on patrons with the most checkouts report (4.70 KB, patch)
2014-07-29 04:44 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
[PASSED QA] Bug 12587 - Improve output of filter information on patrons with the most checkouts report (5.03 KB, patch)
2014-07-30 05:27 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12587: (qa followup) report name consistency (1.22 KB, patch)
2014-09-09 13:50 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-16 15:06:25 UTC
I was looking to see if I could address any of the issues reported in Bug 8126 and saw that handling of filter information could be done better:

- Template logic can be introduced to better handle untranslatable strings coming out of the script.
- Template plugins can be used to output library and item type names instead of codes.
- Template plugin can be used to output dates in the preferred date format.
Comment 1 Owen Leonard 2014-07-16 15:59:30 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-07-29 04:44:35 UTC
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Comment 3 Biblibre Sandboxes 2014-07-29 04:44:54 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-07-30 05:27:00 UTC
Created attachment 30316 [details] [review]
[PASSED QA] Bug 12587 - Improve output of filter information on patrons with the most checkouts report

This patch makes some changes to the way filter information is displayed
after running the patrons with the most checkouts report. Before this
patch several untranslatable English strings would be displayed, and
library and item type codes would be shown instead of descriptions.

To test, go to Reports -> Patrons checking out the most. Enter values
for all the filter options:

- Checkout date from
- Checkout date to
- Checkin date from
- Checkin date to
- Library
- Item type
- Patron category

When you submit the form and view the results you should see your date
submissions formatted according to your selected dateformat system
preference. The library name and item type names should be shown instead
of codes.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Improves translatability of the filters output after running
the report and the readability of them (removing codes).

Note: it would be nice if the read-only would be removed from the date
fields, as forcing people to use the date widget is a known accessibility
issue.
Comment 5 Katrin Fischer 2014-07-30 05:41:48 UTC
Hi Owen, could you provide a follow-up, making the report name on the reports
start page match the table heading and the navigation?
Comment 6 Tomás Cohen Arazi 2014-09-09 13:50:58 UTC
Created attachment 31490 [details] [review]
Bug 12587: (qa followup) report name consistency

Reports home should show the same report name (i.e. "Patrons with the most checkouts")
the report itself uses. It is chosen as it is more idiomatic.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 7 Tomás Cohen Arazi 2014-09-09 13:52:39 UTC
Patch pushed to master.

Thanks Owen!