Bug 12597 - Give better visual indication of currently-selected language in the staff client
Summary: Give better visual indication of currently-selected language in the staff client
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-17 17:04 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12597 - Give better visual indication of currently-selected language in the staff client (58.23 KB, patch)
2014-07-18 15:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12597 - Give better visual indication of currently-selected language in the staff client (8.43 KB, patch)
2014-07-28 16:19 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 12597 - Give better visual indication of currently-selected language in the staff client (8.58 KB, patch)
2014-07-28 21:20 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12597 - Give better visual indication of currently-selected language in the staff client (8.69 KB, patch)
2014-07-30 21:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-17 17:04:07 UTC
I think in previous versions we did better at indicating which of multiple active translations is currently selected. I would like to improve the style of the language menu in the footer to better highlight the current selection.
Comment 1 Owen Leonard 2014-07-18 15:22:58 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-07-26 15:54:46 UTC
Patch does not apply:

Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Failed to merge in the changes.

Version: 3.17.00.010
Comment 3 Owen Leonard 2014-07-28 16:19:40 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2014-07-28 21:20:47 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-07-30 21:15:30 UTC
Created attachment 30358 [details] [review]
[PASSED QA] Bug 12597 - Give better visual indication of currently-selected language in the staff client

There is currently no visual feedback to the user reflecting which of
multiple installed translations is currently selected. I think some
necessary styling didn't make it into the conversion to Bootstrap menus.
This patch attempts to improve things.

Most of the changes are to bring back the previous style of highlighting
the currently selected language. A new change is the addition of the
sub-language code to the display of the menu label if one of that menu
item's sub-languages is selected.

This patch also removes some obsolete CSS which referred to the old menu
system.

To test, apply the patch and install or update multiple languages,
including at least two sub-languages. In my test I used en, en-GB and
de-DE. Clear your browser cache if necessary. Enable all these languages
and test the functionality of the language selection menu in the footer.

- Non-enabled languages should appear as non-bold links.
- When a single language (with no sub-languages) is enabled it should
  appear as bold text.
- When one of multiple sub-languages is enabled that selection in the
  pop-up menu should appear as bold text. The menu label should show in
  bold the language code of the selected sub-language.

Tested with de-DE and de-CH, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as expected, passes all tests. No problems found.
Comment 6 Katrin Fischer 2014-07-30 21:16:17 UTC
I like this, can we do something similar for the Boostrap OPAC as well?
Comment 7 Tomás Cohen Arazi 2014-08-05 23:51:11 UTC
Patch pushed to master.

Thanks Owen!