Bug 12600 - Duplicated use statement in Search.pm
Summary: Duplicated use statement in Search.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Colin Campbell
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-18 08:49 UTC by Colin Campbell
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.82 KB, patch)
2014-07-18 09:02 UTC, Colin Campbell
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12600: remove duplicate use statement from code (1.92 KB, patch)
2014-07-26 22:05 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12600: remove duplicate use statement from code (1.98 KB, patch)
2014-07-27 21:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2014-07-18 08:49:58 UTC
There are two use C4::Charset statements in C4::Search.pm one buried deep in the code for no reason it should be removed
Comment 1 Colin Campbell 2014-07-18 09:02:04 UTC Comment hidden (obsolete)
Comment 2 Colin Campbell 2014-07-18 09:03:00 UTC
amended to flag this as a trivial patch
Comment 3 Bernardo Gonzalez Kriegel 2014-07-26 22:05:16 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-07-27 21:34:11 UTC
Created attachment 30161 [details] [review]
[PASSED QA] Bug 12600: remove duplicate use statement from code

A use C4::Charset was added deep in the body of the code
we have already imported it at the top of the file
(the by convention normal place) As use is executed at compile time
specifying it in the code body does not serve a
useful purpose and detracts from the readability of an already
overly complex subroutine.
Remove the superfluous statement
also removed the tabs introduced to the surrounding lines
by the same commit

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Search still works, no errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2014-08-10 12:39:08 UTC
Patch pushed to master.

Thanks Colin!
Comment 6 Galen Charlton 2014-09-23 20:53:47 UTC
Pushed to 3.16.x for inclusion in 3.16.4.