Bug 12613 - Remove CGI::scrolling_list from koha2marclinks.pl
Summary: Remove CGI::scrolling_list from koha2marclinks.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 766
  Show dependency treegraph
 
Reported: 2014-07-19 19:43 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 12613: Remove CGI::scrolling_list from koha2marclinks.pl (9.44 KB, patch)
2014-07-19 20:03 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12613: Remove CGI::scrolling_list from koha2marclinks.pl (9.54 KB, patch)
2014-07-25 14:38 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 12613: Remove CGI::scrolling_list from koha2marclinks.pl (9.66 KB, patch)
2014-07-28 06:09 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-07-19 19:43:56 UTC
Another one to remove
Comment 1 Bernardo Gonzalez Kriegel 2014-07-19 20:03:00 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-07-25 14:38:32 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-07-28 06:09:12 UTC
Created attachment 30180 [details] [review]
[PASSED QA] Bug 12613: Remove CGI::scrolling_list from koha2marclinks.pl

This patch removes all (2) instances from koha2marclinks.pl.
Also changes dropdowns width on mapping editor, from an
ugly ragged right to a fixed width view.

To test:
1. Apply the patch
2. Go to Administration > Koha to MARC mapping
3. Pulldown in this view has been replaced, check
for regressions: change table type and press Ok,
verify you get Koha fields and tag/subfield appropriate
for each table.
4. Now press 'Edit' on any field, go into mapping editor
5. Check that all pulldowns show tag/subtags relevant
for each group ( 000s ... 900s )
6. Check that current mapping is displayed correctly
7. Check for regressions: unmap, remap, press Ok,
verify, change again.
8. If you can, check display of mapping editor on several
browsers, just in case.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I have tested with Firefox/Iceweasel only.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Also tested in Chromium.
Comment 4 Tomás Cohen Arazi (tcohen) 2014-07-29 14:50:01 UTC
Patch pushed to master.

Thanks Bernardo!