Bug 12624 - Getting all search results in C4::Breeding::Z3950Search, instead of pageful
Summary: Getting all search results in C4::Breeding::Z3950Search, instead of pageful
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Z39.50 / SRU / OpenSearch Servers (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-22 09:27 UTC by Olli-Antti Kivilahti
Modified: 2023-07-15 20:34 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12624 - Getting all search results in C4::Breeding::Z3950Search, instead of pageful (4.66 KB, patch)
2014-07-22 09:28 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2014-07-22 09:27:48 UTC
Fetching ALL component parts from a remote Z3950 repository is difficult.
Also the Z3950Search() function only works directly to templates.

This patch changes the Z3950Search() to OPTIONALLY return all search results as a HASH instead of a Template-object.

This makes scripting with it a LOT easier!
Comment 1 Olli-Antti Kivilahti 2014-07-22 09:28:47 UTC
Created attachment 29949 [details] [review]
Bug 12624 - Getting all search results in C4::Breeding::Z3950Search, instead of pageful

Fetching ALL component parts from a remote Z3950 repository is difficult.
Also the Z3950Search() function only works directly to templates.

This patch changes the Z3950Search() to OPTIONALLY return all search results as a HASH instead of a Template-object.
Previous functionality is left untouched.

This makes scripting with it a LOT easier!
Comment 2 Marcel de Rooy 2014-07-23 11:22:08 UTC
Does this still work on top of bug 6536 ?
Comment 3 Olli-Antti Kivilahti 2014-07-23 11:28:28 UTC
Probably not, thanks for pointing it out.

I second that bug 6536 takes precedence over this one. I'll refactor this as needed.
Comment 4 Marcel de Rooy 2014-07-23 11:36:54 UTC
(In reply to Olli-Antti Kivilahti from comment #3)
> Probably not, thanks for pointing it out.
> 
> I second that bug 6536 takes precedence over this one. I'll refactor this as
> needed.

I still wanted to touch that paging stuff some time..
Comment 5 Olli-Antti Kivilahti 2014-07-23 11:47:22 UTC
You are free to refactor my patch or substitute it with your own if you are in a hurry.

Just please submit it here so I can utilize it as well.
Comment 6 Katrin Fischer 2023-07-15 20:34:48 UTC
It looks like this hasn't changed yet - is it still a change we are interested in?