Bug 12635 - Course reserves item list should use "Checked out" instead of "On Loan"
Summary: Course reserves item list should use "Checked out" instead of "On Loan"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Course reserves (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/course_reserves/course-...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-23 13:46 UTC by Owen Leonard
Modified: 2015-06-04 23:32 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12635 - Course reserves item list should use "Checked out" instead of "On Loan" (1.96 KB, patch)
2014-07-29 19:10 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 12635 - Course reserves item list should use "Checked out" instead of "On Loan" (2.14 KB, patch)
2014-07-30 06:07 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12635 - Course reserves item list should use "Checked out" instead of "On Loan" (2.22 KB, patch)
2014-07-30 21:01 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-23 13:46:34 UTC
Koha uses the phrase "checked out" in the default en translation instead of "on loan."

Also incorrect: Capitalization of "Item Lost."
Comment 1 Robert Higgins 2014-07-25 03:03:41 UTC
Can't replicate. Please add replication steps.
Comment 2 Katrin Fischer 2014-07-27 19:02:51 UTC
I think the problem is a missing step-by-step that would be helpful for testers without knowledge of the course reserves module. I am switching back to new - in discussion is more for general disagreements about the approach of a fix or similar.
Comment 3 Owen Leonard 2014-07-29 19:10:34 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2014-07-30 06:07:07 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-07-30 21:01:38 UTC
Created attachment 30357 [details] [review]
[PASSED QA] Bug 12635 - Course reserves item list should use "Checked out" instead of "On Loan"

When viewing the list of items on a course reserve list, if the item is
checked out it is indicated by the phrase "On Loan." The default
templates should always use "checked out" instead of "on loan." Also
corrected: the capitalization of "Item Lost."

To test, Course Reserves must be enabled and you must have an existing
course reserves with items on it, one of which should be checked out.
View the list of items on that Course Reserve and confirm that the table
says "Checked out."

Table in staff client displays "Checked out" / "Item lost"
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
String change, no problems found.
Comment 6 Tomás Cohen Arazi 2014-08-07 14:59:48 UTC
Patch pushed to master.

Thanks Owen!