Bug 12639 - Z39.50 administration page should use "message" dialog for adds and updates
Summary: Z39.50 administration page should use "message" dialog for adds and updates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-23 17:06 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 12639 - Z39.50 administration page should use "message" dialog for adds and updates (1.73 KB, patch)
2014-07-24 14:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12639 - Z39.50 administration page should use "message" dialog for adds and updates (1.77 KB, patch)
2014-07-25 05:21 UTC, Petter Goksøyr Åsen
Details | Diff | Splinter Review
[PASSED QA] Bug 12639 - Z39.50 administration page should use "message" dialog for adds and updates (1.87 KB, patch)
2014-07-25 06:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-23 17:06:08 UTC
When a Z39.50 server is added or updated the page outputs a message to the screen using a box styled as "dialog alert." It should use "dialog message" instead.
Comment 1 Owen Leonard 2014-07-24 14:49:51 UTC Comment hidden (obsolete)
Comment 2 Petter Goksøyr Åsen 2014-07-25 05:21:00 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-07-25 06:32:24 UTC
Created attachment 30073 [details] [review]
[PASSED QA] Bug 12639 - Z39.50 administration page should use "message" dialog for adds and updates

This patch changes the style of a couple of message boxes to use the
"message" style instead of the "alert" style. This better reflects the
type and priority of the messages being displayed.

To test, got to Administration -> Z39.50 client targets and edit an
existing server. The confirmation message should be the blue "message"
type.

Test again by adding a new server. The confirmation message for this
operation should be of the same blue "message" type.

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Small template change, tested ok.
Comment 4 Tomás Cohen Arazi (tcohen) 2014-07-26 13:21:23 UTC
Patch pushed to master.

Thanks Owen!