This patch will conflict with http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
(In reply to Dobrica Pavlinusic from comment #1) > This patch will conflict with > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Don't worry, nobody has tested it. But also, it does not change database values.
Created attachment 30028 [details] [review] Bug 12649 - Add Croatian language
(In reply to Dobrica Pavlinusic from comment #3) > Created attachment 30028 [details] [review] [review] > Bug 12649 - Add Croatian language It's ready for signing?
Created attachment 30029 [details] [review] Bug 12649 - Add Croatian language
It is now :-)
(In reply to Dobrica Pavlinusic from comment #6) > It is now :-) Two things: 1) Line 8551 on updatedatbase.pl, a missing ')' SetVersion($DBversion; -> SetVersion($DBversion); file does not run :( 2) There are no changes for these languages it-IT nb-NO uk-UA Save for that, patch works. Don't forget a commit message with test plan!
Thanks for spotting upatedatabase.pl corruption, I missed other languages which doesn't have mandatory subdir, sigh.
Created attachment 30034 [details] [review] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available
Created attachment 30038 [details] [review] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available
Last change fixes typo in updatedatabase.pl. I think it's ready now.
Created attachment 30039 [details] [review] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available
Created attachment 30042 [details] [review] [SIGNED-OFF] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors. Also tested translating to de-DE and on advanced search opac/staff is listed translated.
Created attachment 30047 [details] [review] [PASSED QA] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors. Also tested translating to de-DE and on advanced search opac/staff is listed translated. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Note: This also makes the language show up in the language pull down in advanced search. Because the entry is the last in the file, it will show last in the list. I am noting this here, the list is not really consistently sorted right now and there is work under way to change the way we handle this.
Created attachment 30145 [details] [review] Bug 12649: followup to add Croatian into french
Patch pushed to master. Thanks Dobrica!