When installing Koha, there is a screen that asks you which options you want to install. Currently there is a sea of tick boxes, that you need to ninja click in order to tick them all, this can be rather time consuming and prone to error (it is easy to miss one for instance). Proposed resolution =================== * A new hyperlink at the top of the installer that adds a "Select all" option for users with Javascript enabled. * Each label for the checkbox will also get a corresponding <label for""> HTML tag around it, allowing the user to click on the label instead of the tiny checkbox.
Created attachment 30058 [details] [review] proposed patch Patch attached that implements this. Test steps in patch notes.
Created attachment 30644 [details] [review] [SIGNED OFF] Bug 12658: Installter step 3 - select framework "select all" button, labels and misc HTML formatting issues. To test: 1/ Visit /cgi-bin/koha/installer/install.pl?step=3&op=selectframeworks 2/ Assert you can see a link "Select all frameworks" (with JavaScript enabled) 3/ Assert when you click the "Select all frameworks" link all checkboxes are now ticked on the page 4/ Assert when you click on the text next to a checkbox, that it will toogle the corresponding checkbox (accessibility) 5/ Assert there is less unclosed HTML tags on the page (should be none on the select framework page now) 6/ Assert the installer still functions as expected for a clean install Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Link says "Select all frameworks" perhaps "Select all options" or "Select all" would be clearer, but seems to work as desired Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Hi Sean, I really like this :) There is just one small problem, that could cause a bit of confusion - frameworks in Koha refer to the cataloguing frameworks (different forms for different type of media), so only to the first few checkboxes on the page. I don't want to change all the occurences of framework in your patch - so I am going to do a follow up just changing the link to say "select all sample data" - hope this is ok
Hm, the link is in the Javascript and not translatable currently. Needs a little bit more thought - failing to get it right at the moment.
Created attachment 30649 [details] [review] [Follow-up] Wording of link text and translatability inside JavaScript This patch changes 'Select all frameworks' to 'Select all sample data' and exposes it to translation through function _(). To test: Apply first patch. See "Select all frameworks" on Webinstaller > Step3 Apply second patch Text changes to "Select all sample data" Check translation Check for JavaScript errors
Created attachment 30656 [details] [review] [PASSED QA] Bug 12658: Installter step 3 - select framework "select all" button, labels and misc HTML formatting issues. To test: 1/ Visit /cgi-bin/koha/installer/install.pl?step=3&op=selectframeworks 2/ Assert you can see a link "Select all frameworks" (with JavaScript enabled) 3/ Assert when you click the "Select all frameworks" link all checkboxes are now ticked on the page 4/ Assert when you click on the text next to a checkbox, that it will toogle the corresponding checkbox (accessibility) 5/ Assert there is less unclosed HTML tags on the page (should be none on the select framework page now) 6/ Assert the installer still functions as expected for a clean install Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Link says "Select all frameworks" perhaps "Select all options" or "Select all" would be clearer, but seems to work as desired Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 30657 [details] [review] [PASSED QA] Bug 12658: Wording of link text and translatability inside JavaScript This patch changes 'Select all frameworks' to 'Select all sample data' and exposes it to translation through function _(). To test: Apply first patch. See "Select all frameworks" on Webinstaller > Step3 Apply second patch Text changes to "Select all sample data" Check translation Check for JavaScript errors http://bugs.koha-community.org/show_bug.cgi?id=12658 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changes link text and also makes it translatable.
Thx Marc for helping me out with the qa follow-up!
Patches pushed to master. Thanks Sean and Marc! Great job!