Bug 12658 - Select all options on installer screen
Summary: Select all options on installer screen
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Sean Hamlin
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-24 23:52 UTC by Sean Hamlin
Modified: 2015-06-04 23:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (9.89 KB, patch)
2014-07-25 02:09 UTC, Sean Hamlin
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12658: Installter step 3 - select framework "select all" button, labels and misc HTML formatting issues. (10.14 KB, patch)
2014-08-09 05:21 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
[Follow-up] Wording of link text and translatability inside JavaScript (2.19 KB, patch)
2014-08-09 13:00 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12658: Installter step 3 - select framework "select all" button, labels and misc HTML formatting issues. (10.19 KB, patch)
2014-08-10 14:05 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12658: Wording of link text and translatability inside JavaScript (2.30 KB, patch)
2014-08-10 14:06 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Hamlin 2014-07-24 23:52:40 UTC
When installing Koha, there is a screen that asks you which options you want to install. Currently there is a sea of tick boxes, that you need to ninja click in order to tick them all, this can be rather time consuming and prone to error (it is easy to miss one for instance).

Proposed resolution
===================
* A new hyperlink at the top of the installer that adds a "Select all" option for users with Javascript enabled.
* Each label for the checkbox will also get a corresponding <label for""> HTML tag around it, allowing the user to click on the label instead of the tiny checkbox.
Comment 1 Sean Hamlin 2014-07-25 02:09:19 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2014-08-09 05:21:18 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-09 09:20:42 UTC
Hi Sean, I really like this :)

There is just one small problem, that could cause a bit of confusion - frameworks in Koha refer to the cataloguing frameworks (different forms for different type of media), so only to the first few checkboxes on the page.

I don't want to change all the occurences of framework in your patch - so I am going to do a follow up just changing the link to say "select all sample data" - hope this is ok
Comment 4 Katrin Fischer 2014-08-09 09:59:15 UTC
Hm, the link is in the Javascript and not translatable currently. Needs a little bit more thought - failing to get it right at the moment.
Comment 5 Marc Véron 2014-08-09 13:00:56 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-08-10 14:05:50 UTC
Created attachment 30656 [details] [review]
[PASSED QA] Bug 12658: Installter step 3 - select framework "select all" button, labels and misc HTML formatting issues.

To test:
1/ Visit /cgi-bin/koha/installer/install.pl?step=3&op=selectframeworks
2/ Assert you can see a link "Select all frameworks" (with JavaScript enabled)
3/ Assert when you click the "Select all frameworks" link all checkboxes are now ticked on the page
4/ Assert when you click on the text next to a checkbox, that it will toogle the corresponding checkbox (accessibility)
5/ Assert there is less unclosed HTML tags on the page (should be none on the select framework page now)
6/ Assert the installer still functions as expected for a clean install

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Link says "Select all frameworks"  perhaps "Select all options" or "Select all" would be clearer, but seems to work as desired

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 7 Katrin Fischer 2014-08-10 14:06:27 UTC
Created attachment 30657 [details] [review]
[PASSED QA] Bug 12658: Wording of link text and translatability inside JavaScript

This patch changes 'Select all frameworks' to 'Select all sample data' and exposes it to translation through function _().

To test:
Apply first patch.
See "Select all frameworks" on Webinstaller > Step3
Apply second patch
Text changes to "Select all sample data"
Check translation
Check for JavaScript errors

http://bugs.koha-community.org/show_bug.cgi?id=12658
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changes link text and also makes it translatable.
Comment 8 Katrin Fischer 2014-08-10 14:06:57 UTC
Thx Marc for helping me out with the qa follow-up!
Comment 9 Tomás Cohen Arazi 2014-08-15 18:48:00 UTC
Patches pushed to master.

Thanks Sean and Marc! Great job!