Bug 12662 - Ajax-based check in does not work for some system preference settings enabled
Summary: Ajax-based check in does not work for some system preference settings enabled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jacek Ablewicz
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-25 08:55 UTC by Jacek Ablewicz
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12662 - Ajax-based check in does not work for some system preference settings enabled (1.26 KB, patch)
2014-07-25 09:06 UTC, Jacek Ablewicz
Details | Diff | Splinter Review
Bug 12662 - Ajax-based check in does not work for some system preference settings enabled (1.32 KB, patch)
2014-07-25 10:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled (803 bytes, patch)
2014-07-25 10:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled (1.39 KB, patch)
2014-07-25 13:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled (874 bytes, patch)
2014-07-25 13:42 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Ablewicz 2014-07-25 08:55:15 UTC
To reproduce:

- enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference,
- for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs,
- observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed.
Comment 1 Jacek Ablewicz 2014-07-25 09:06:21 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-07-25 10:43:57 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-07-25 10:44:01 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-07-25 10:44:51 UTC
Before your patch, I got
[Fri Jul 25 12:41:22 2014] checkin: Undefined subroutine &main::GetItem called at /home/koha/src/svc/checkin line 58.

And after:
[Fri Jul 25 12:42:09 2014] checkin: Undefined subroutine &main::ModItem called at /home/koha/src/svc/checkin line 68.


:)

But after yours and mine, only warnings...
Comment 5 Kyle M Hall 2014-07-25 13:42:36 UTC
Created attachment 30105 [details] [review]
[PASSED QA] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled

To reproduce:

- enable "InProcessingToShelvingCart" or "ReturnToShelvingCart"
system preference,
- for a sample patron with 1+ checkouts, try to check in some item[s]
using checkboxes in the "Check in" column in the checkouts table
which is displayed in the "Check out" or "Details" patron account tabs,
- observe that clicking "Renew or return checked items" button only
results in ajax "spinning wheel" stuck in infinite loop; check-in
operation is not performed.

To test:

- follow the steps above to reproduce this bug
- apply patch
- redo the test; ensure that this issue is no longer reproductible.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2014-07-25 13:42:46 UTC
Created attachment 30106 [details] [review]
[PASSED QA] Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled

ModItem is needed too.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2014-07-30 17:52:31 UTC
Patches pushed to master.

Thanks Jacek"
Comment 8 Galen Charlton 2014-08-26 22:45:39 UTC
Pushed to 3.16.x for inclusion in 3.16.3.