Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information
Summary: Use NoLoginInstructions to customize text for OPAC user/pass information
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P4 enhancement (vote)
Assignee: simith.doliveira
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-31 15:05 UTC by simith.doliveira
Modified: 2015-06-04 23:33 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information (3.70 KB, patch)
2014-07-31 17:02 UTC, simith.doliveira
Details | Diff | Splinter Review
[Signed-off] Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information (3.88 KB, patch)
2014-08-01 09:12 UTC, Marc Véron
Details | Diff | Splinter Review
Popup correction patch. (2.97 KB, patch)
2014-08-12 14:24 UTC, simith.doliveira
Details | Diff | Splinter Review
[Signed-off] Popup correction patch. (3.16 KB, patch)
2014-08-12 15:00 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information (3.88 KB, patch)
2014-08-13 11:20 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 12683: Follow-up, adding div tags around NoLoginInstructions (3.14 KB, patch)
2014-08-13 11:20 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 12683: (followup) use the Koha.Preference plugin and add ids (4.24 KB, patch)
2014-08-15 14:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description simith.doliveira 2014-07-31 15:05:09 UTC

    
Comment 1 simith.doliveira 2014-07-31 17:02:06 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-08-01 09:12:14 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-08-07 11:30:15 UTC
QA Comment:
In case you click on Log in to your account in the top bar, a login popup appears. In that case the NoLoginInstructions are next to the password and not below the password as suggested.
This is just a small design thing, but it does not look good.

Failed QA
Comment 4 simith.doliveira 2014-08-12 14:24:02 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2014-08-12 15:00:13 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2014-08-13 11:20:46 UTC
Created attachment 30750 [details] [review]
Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information

Enable staff to setting a text for OPAC user/pass information

Modified:

C4/Auth.pm
koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc   -add a text to the popup login page
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-main.tt   -add a text to the main login page

Testing:

I Apply the patch

0) Search NoLoginInstructions preference
1) Add/modify a text
2) Open OPAC main page
3) Validate the text added under Login button
4) Click in "Log in to your account" link
5) Validate the text added under input password (popup)

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

Patch behaves as expected.
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Marcel de Rooy 2014-08-13 11:20:50 UTC
Created attachment 30751 [details] [review]
Bug 12683: Follow-up, adding div tags around NoLoginInstructions

Button in pop-up displays now as expected.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Tomás Cohen Arazi 2014-08-15 14:10:21 UTC
Created attachment 30839 [details] [review]
Bug 12683: (followup) use the Koha.Preference plugin and add ids

It is kosher now to use the Koha template toolkit plugin for retrieving
system preferences values. This followup does that.

It also changes the class for ids, for people considering this patch
introduces too much noise on the home screen being able to control
its visibility.

Regards
To+

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 9 Tomás Cohen Arazi 2014-08-15 14:11:13 UTC
Patches pushed to master.

Thanks Simith!
Comment 10 Jacek Ablewicz 2014-08-25 06:32:59 UTC
(In reply to Tomás Cohen Arazi from comment #8)
> Created attachment 30839 [details] [review] [review]
> Bug 12683: (followup) use the Koha.Preference plugin and add ids
> 
> It is kosher now to use the Koha template toolkit plugin for retrieving
> system preferences values. This followup does that.

I agree it's kinda kosher that way ;) but the problem is, for a current master such a change seems to introduce rather nasty side effects regarding UFT-8 characters encoding in great many OPAC pages; see bug 12411 for details.