Bug 12686 - Make more selected option XHTML complian
Summary: Make more selected option XHTML complian
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-31 18:50 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12686: Make more selected option XHTML compliant (18.07 KB, patch)
2014-07-31 18:52 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12686: Make more selected option XHTML compliant (18.16 KB, patch)
2014-07-31 18:55 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12686: Make more selected option XHTML compliant (18.26 KB, patch)
2014-07-31 19:23 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 12686: Make more selected option XHTML compliant (18.26 KB, patch)
2014-08-02 20:33 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-07-31 18:50:06 UTC
Need to be <option ... selected="selected">...</option>
Comment 1 Bernardo Gonzalez Kriegel 2014-07-31 18:52:37 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-07-31 18:55:55 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-07-31 19:23:07 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-08-02 20:33:21 UTC
Created attachment 30497 [details] [review]
[PASSED QA] Bug 12686: Make more selected option XHTML compliant

This patch fixes several occurrences of selected
options that do not follow XHTML style rule for
markup.

To test:
1. Apply the patch
2. There are no functional changes at all,
only a more strict markup

Changed all cases I can found.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2014-08-07 14:59:25 UTC
Patch pushed to master.

Thanks Bernardo!