Bug 12688 - Better IntranetNav
Summary: Better IntranetNav
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-31 22:17 UTC by Christopher Brannon
Modified: 2016-12-05 21:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Cleaned up IntranetNav (17.45 KB, image/png)
2014-07-31 22:17 UTC, Christopher Brannon
Details
Basic links in IntranetNav (14.66 KB, image/png)
2014-08-01 15:22 UTC, Christopher Brannon
Details
Not so attractive layout of links in IntranetNav (31.53 KB, image/png)
2014-08-01 15:22 UTC, Christopher Brannon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2014-07-31 22:17:59 UTC
Created attachment 30440 [details]
Cleaned up IntranetNav

I've noticed that if you just throw some links into IntranetNav, it just makes the nav line wrap after just a couple additions.  Plus the added links don't look good, and don't line up well.

I've managed to mimic the More menu by stealing the code and pasting it into IntranetNav, then updating the labels and links.  Here is the code I put into our IntranetNav:

<li class="dropdown">
<a class="dropdown-toggle" data-toggle="dropdown" href="#">
Resources
<b class="caret"></b>
</a>
<ul class="dropdown-menu">
<li>
<a href="http://worldcat.org/" target="_blank">WorldCat</a>
</li>
<li>
<a href="http://www.goodreads.com/" target="_blank">goodreads</a>
</li>
<li>
<a href="http://www.cinlibraries.org/" target="_blank">CIN Website</a>
</li>
</ul>
</li>

It would be great if this structure was somehow built into the IntranetNav preference.  It is much cleaner and behaves better.

Christopher
Comment 1 Owen Leonard 2014-08-01 00:38:44 UTC
> Plus the added links
> don't look good, and don't line up well.

I'm not seeing a problem with the way the links look when I test it. Does it depend on the browser? What is the markup you're testing which looks wrong?
Comment 2 Christopher Brannon 2014-08-01 15:21:17 UTC
(In reply to Owen Leonard from comment #1)
> > Plus the added links
> > don't look good, and don't line up well.
> 
> I'm not seeing a problem with the way the links look when I test it. Does it
> depend on the browser? What is the markup you're testing which looks wrong?

Well, if you only throw links in there, the font doesn't match, the links are run together, and they are offset from the rest of the menu.  It just doesn't look clean.  Plus, as I said, you are limited on space.  (See attachments)

I just thought I'd throw this out there.  Seems like mimicking the existing menu is more attractive and practical.

Christopher
Comment 3 Christopher Brannon 2014-08-01 15:22:05 UTC
Created attachment 30457 [details]
Basic links in IntranetNav
Comment 4 Christopher Brannon 2014-08-01 15:22:46 UTC
Created attachment 30458 [details]
Not so attractive layout of links in IntranetNav
Comment 5 Christopher Brannon 2014-08-01 15:25:56 UTC
(In reply to Owen Leonard from comment #1)
> > Plus the added links
> > don't look good, and don't line up well.
> 
> I'm not seeing a problem with the way the links look when I test it. Does it
> depend on the browser? What is the markup you're testing which looks wrong?

I am using FireFox, by the way. IE11 looks exactly the same.

Christopher
Comment 6 Owen Leonard 2014-08-01 15:31:44 UTC
(In reply to Christopher Brannon from comment #2)
> Well, if you only throw links in there, the font doesn't match, the links
> are run together, and they are offset from the rest of the menu.

Yeah it's not exactly clear from the system preference description, but for it to look consistent you have to enter them as list items:

<li><a href="#">Link one</a></li>
<li><a href="#">Link two</a></li>
<li><a href="#">Link three</a></li>

That said, you're right that you'll run out of space quickly. I'm glad you were able to put together a menu that worked. Perhaps a good next step would be to fully document both the plain and menu markup options.