Currently, we're loading "opacuserjs" in sco-main.tt twice. Once at the very bottom at the template, and once via opac-bottom.inc.
Created attachment 30441 [details] [review] Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once.
Created attachment 30444 [details] [review] [Signed-off] Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 30501 [details] [review] [PASSED QA] Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> opac-bottom.inc already adds opacuserjs, so the additional line in this template can be removed. Works as described, no problems found.
Patch pushed to master. Thanks David!