Bug 12690 - opacuserjs gets loaded twice in self checkout
Summary: opacuserjs gets loaded twice in self checkout
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-01 06:30 UTC by David Cook
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12690 - opacuserjs gets loaded twice in self checkout (1.33 KB, patch)
2014-08-01 06:55 UTC, David Cook
Details | Diff | Splinter Review
[Signed-off] Bug 12690 - opacuserjs gets loaded twice in self checkout (1.51 KB, patch)
2014-08-01 08:10 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12690 - opacuserjs gets loaded twice in self checkout (1.69 KB, patch)
2014-08-02 21:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2014-08-01 06:30:13 UTC
Currently, we're loading "opacuserjs" in sco-main.tt twice. Once at the very bottom at the template, and once via opac-bottom.inc.
Comment 1 David Cook 2014-08-01 06:55:13 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-08-01 08:10:00 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-02 21:35:09 UTC
Created attachment 30501 [details] [review]
[PASSED QA] Bug 12690 - opacuserjs gets loaded twice in self checkout

This patch removes a second instance of "opacuserjs" in the opac
self-checkout.

_TEST PLAN_

1) Enable OPAC Self-checkout in the system preferences
2) Type the following code into your "opacuserjs" system preference:

alert("This is a test");

2) Visit /cgi-bin/koha/sco/sco-main.pl
3) Note that you get a pop-up saying "This is a test" twice.

4) Apply the patch

5) Refresh /cgi-bin/koha/sco/sco-main.pl
6) Note that you now only get a pop-up saying "This is a test" once.

Followed test plan, patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
opac-bottom.inc already adds opacuserjs, so the additional line
in this template can be removed.
Works as described, no problems found.
Comment 4 Tomás Cohen Arazi 2014-08-05 23:28:50 UTC
Patch pushed to master.

Thanks David!