Bug 12700 - Capitalization: "Close Help Window" in context help
Summary: Capitalization: "Close Help Window" in context help
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-02 20:38 UTC by Katrin Fischer
Modified: 2015-06-04 23:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12700 - Capitalization: "Close Help Window" in context help (1.38 KB, patch)
2014-08-03 09:57 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12700 - Capitalization: "Close Help Window" in context help (1.48 KB, patch)
2014-08-07 19:53 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12700 - Capitalization: "Close Help Window" in context help (1.52 KB, patch)
2014-08-07 21:13 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
[PASSED QA] Bug 12700 - Capitalization: "Close Help Window" in context help (1.59 KB, patch)
2014-08-10 21:22 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-08-02 20:38:29 UTC
"Close Help Window" should be "Close help window" according to our guidelines.
The text is visible on every help page reached by clicking on Help in the top right corner.
Comment 1 Marc Véron 2014-08-03 09:57:40 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-08-07 19:53:51 UTC Comment hidden (obsolete)
Comment 3 Biblibre Sandboxes 2014-08-07 21:13:32 UTC
Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org>
Comment 4 Biblibre Sandboxes 2014-08-07 21:13:50 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-08-10 21:22:57 UTC
Created attachment 30669 [details] [review]
[PASSED QA] Bug 12700 - Capitalization: "Close Help Window" in context help

To test:
- Open help in any page of staff client
- In help popup window, see wrong capitalization in button 'Close Help Window'
- Close the popup window
- Apply patch
- Check again: Button now reads "Close help window'

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no koha-qa errors

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2014-08-11 14:52:04 UTC
Patch pushed to master.

Thanks Marc!