Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl"
Summary: Turn off Authority logging when running "bulkmarcimport.pl"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-05 07:03 UTC by David Cook
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" (2.53 KB, patch)
2014-08-06 05:29 UTC, David Cook
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" (2.79 KB, patch)
2014-08-06 19:56 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" (2.94 KB, patch)
2014-08-18 22:01 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12720: (QA followup) use API instead of plain SQL (2.57 KB, patch)
2014-08-24 16:21 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2014-08-05 07:03:20 UTC
Currently, there is no provision to disable logging when running "bulkmarcimport.pl" in authority mode.

There is for bibliographic mode, and it seems to presumably be for performance reasons. (I would think both in terms of the import and in terms of querying the action_logs table, as that could get quite cumbersome if you import 600,000 authorities.)
Comment 1 David Cook 2014-08-06 05:29:02 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-08-06 19:56:46 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-18 22:01:53 UTC
Created attachment 30956 [details] [review]
[PASSED QA] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl"

This patch turns off the AuthoritiesLogging syspref when running the
bulkmarcimport.pl script.

It also temporarily disables the syspref caching which will have
been making the CataloguingLogging handling ineffectual. (That is,
updating the CataloguingLogging syspref in the script wouldn't
have an effect as the original cached value would be used anyway.)

_TEST PLAN_

0) Turn on "AuthoritiesLogging" syspref
1) Load an authority record using bulkmarcimport.pl
2) Note a new Authorities entry in action_logs

3) Apply the patch

4) Repeat Step 1
5) Note that no new entry is made in action_logs

(Bonus points: Do the same thing with CataloguingLogging and a
bibliographic record.)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested with biblio and auth imports.
Work as described, no koha-qa errors.

Note: If you begin to load a big file and get impatient and hit ^C,
seems that current syspref value is lost...

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script.
Patch copies what was already done for the CatalougingLog, no problems found.
Comment 4 Tomás Cohen Arazi 2014-08-24 16:21:38 UTC
Created attachment 31127 [details] [review]
Bug 12720: (QA followup) use API instead of plain SQL

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 5 Tomás Cohen Arazi 2014-08-24 16:32:10 UTC
Patch pushed to master.

Thanks David!