Bug 12744 - Set library in staff client should have 'Cancel' link
Summary: Set library in staff client should have 'Cancel' link
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-11 14:13 UTC by Marc Véron
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12744 - Set language in staff client should have 'Cancel' link (1.51 KB, patch)
2014-08-11 14:28 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12744 - Set language in staff client should have 'Cancel' link (1.55 KB, patch)
2014-08-11 15:30 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12744 - Set language in staff client should have 'Cancel' link (1.54 KB, patch)
2014-08-11 15:37 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12744 - Set language in staff client should have 'Cancel' link (1.63 KB, patch)
2014-08-12 16:35 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 12744 - Set language in staff client should have 'Cancel' link (1.68 KB, patch)
2014-08-16 20:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2014-08-11 14:13:46 UTC

    
Comment 1 Marc Véron 2014-08-11 14:28:17 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-08-11 14:50:44 UTC
This works great for me, but I have one minor issue: The "Cancel" link should not have an empty "onclick" attribute.
Comment 3 Marc Véron 2014-08-11 15:09:00 UTC
I followed a pattern from an other place with 'Cancel'

Would the following be better?

<a class="cancel" id="cancel_set_library" href="[% referer or '/cgi-bin/koha/circ/circulation.pl' %]">Cancel</a>
Comment 4 Owen Leonard 2014-08-11 15:17:52 UTC
(In reply to Marc Véron from comment #3)
> Would the following be better?
> 
> <a class="cancel" id="cancel_set_library" href="[% referer or
> '/cgi-bin/koha/circ/circulation.pl' %]">Cancel</a>

Yes. If you found instances where there is an empty onclick attribute the onclick should be removed.
Comment 5 Marc Véron 2014-08-11 15:30:05 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2014-08-11 15:32:14 UTC
Mistaked with git add. New patch follows.
Comment 7 Marc Véron 2014-08-11 15:37:14 UTC Comment hidden (obsolete)
Comment 8 Owen Leonard 2014-08-12 16:35:40 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2014-08-16 20:32:53 UTC
Created attachment 30876 [details] [review]
[PASSED QA] Bug 12744 - Set language in staff client should have 'Cancel' link

Test plan

Without patch:
Click on Library name in head of any staff client page anc choose 'Set library'
Result: Form 'Set library' with no 'Cancel' near 'Submit' button

With patch:
Form displays 'Cancel' link.
This link closes the form and takes you back to the page where you came from.

New patch without empty "onclick" attribute.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Nice patch, no problems found.
Comment 10 Tomás Cohen Arazi 2014-08-24 16:26:09 UTC
Patch pushed to master.

Thanks Marc!