As Owen Leonard remarked in Bug 17744, empty onclick attribute should be removed. Git grep 'onclick=""' lists memberentrygen.tt only.
Created attachment 30708 [details] [review] Bug 12746 - Remove empty onclick attribute from memberentrygen.tt This patch removes empty onclick attribute from memberentrygen.tt To test: Apply patch. Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes Go to Home > patrons and click 'New patron' Check HTML of 'Cancel' link Make sure that 'Cancel' link still works
Created attachment 30745 [details] [review] [SIGNED-OFF] Bug 12746 - Remove empty onclick attribute from memberentrygen.tt This patch removes empty onclick attribute from memberentrygen.tt To test: Apply patch. Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes Go to Home > patrons and click 'New patron' Check HTML of 'Cancel' link Make sure that 'Cancel' link still works Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 30825 [details] [review] [PASSED QA] Bug 12746 - Remove empty onclick attribute from memberentrygen.tt This patch removes empty onclick attribute from memberentrygen.tt To test: Apply patch. Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes Go to Home > patrons and click 'New patron' Check HTML of 'Cancel' link Make sure that 'Cancel' link still works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changes the link to cancel adding a manual restriction. No regressions found.
Patch pushed to master. Thanks Marc!