Bug 12746 - Remove empty onclick attribute from memberentrygen.tt
Summary: Remove empty onclick attribute from memberentrygen.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-11 15:45 UTC by Marc Véron
Modified: 2015-06-04 23:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12746 - Remove empty onclick attribute from memberentrygen.tt (1.35 KB, patch)
2014-08-11 15:57 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12746 - Remove empty onclick attribute from memberentrygen.tt (1.43 KB, patch)
2014-08-12 16:13 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 12746 - Remove empty onclick attribute from memberentrygen.tt (1.53 KB, patch)
2014-08-15 10:08 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2014-08-11 15:45:27 UTC
As Owen Leonard remarked in Bug 17744, empty onclick attribute should be removed. 

Git grep 'onclick=""' lists memberentrygen.tt only.
Comment 1 Marc Véron 2014-08-11 15:57:32 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-08-12 16:13:20 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-15 10:08:32 UTC
Created attachment 30825 [details] [review]
[PASSED QA] Bug 12746 - Remove empty onclick attribute from memberentrygen.tt

This patch removes empty onclick attribute from memberentrygen.tt

To test:
Apply patch.
Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes
Go to Home > patrons  and click 'New patron'
Check HTML of 'Cancel' link
Make sure that 'Cancel' link still works

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changes the link to cancel adding a manual restriction.
No regressions found.
Comment 4 Tomás Cohen Arazi 2014-09-08 13:57:14 UTC
Patch pushed to master.

Thanks Marc!