Bug 12753 - Warnings in t/SIP_Sip.t could be tested
Summary: Warnings in t/SIP_Sip.t could be tested
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Chris Cormack
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-12 22:55 UTC by Tomás Cohen Arazi
Modified: 2015-06-04 23:32 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12753: Warnings in t/SIP_Sip.t could be tested (2.16 KB, patch)
2014-08-12 23:00 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 12753: Warnings in t/SIP_Sip.t could be tested (2.20 KB, patch)
2014-08-12 23:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 12753: Warnings in t/SIP_Sip.t could be tested (2.29 KB, patch)
2014-08-17 08:50 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 12753: Warnings in t/SIP_Sip.t could be tested (2.40 KB, patch)
2014-08-17 09:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2014-08-12 22:55:58 UTC
Warnings are a feature some functions provide (i.e. expected behaviour) and can be tested. In this case, warnings raised by t/SIP_Sip.t
Comment 1 Tomás Cohen Arazi 2014-08-12 23:00:56 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2014-08-12 23:04:14 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2014-08-17 08:50:53 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-08-17 09:04:00 UTC
Created attachment 30890 [details] [review]
[PASSED QA] Bug 12753: Warnings in t/SIP_Sip.t could be tested

A C4::SIP warning is expected and should be tested.

To test:
- Run
  $ prove -v t/SIP_Sip.t
=> FAIL: A warning is printed to STDOUT
- Apply the patch
- Run
  $ prove -v t/SIP_Sip.t
=> SUCCESS: No warnings on STDOUT, a new test verifying the warning is added.
- It was an easy one, smile and sign off :-D

Sponsored-by: The Will to Procrastinate
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Sponsored-by: Sunday TV is boring
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Sponsored-by: Avoiding distance study homework
Comment 5 Tomás Cohen Arazi 2014-08-19 12:35:44 UTC
Patch pushed to master.