It would be a great timesaver if the records associated with a particular list can be passed into the Batch item modification and batch item deletion tools. At the moment I have to run a report to extract the item barcode numbers from the list then open the resulting spreadsheet and copy & paste these into the batch modification tool. Ideally the batch modification/deletion tools need another input option to choose a particular list (that you can access), or alternatively have a new option in the list view screen to pass selected records to batch modification/deletion.
Along these same lines, it would be great to be able to use the batch modification (or other method) to add a batch of bib/items to a list.
Created attachment 60297 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the list from the dropdown, select a modification template, Continue 4) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 5) Go to Batch record deletion 6) Select the list from the dropdown and click Continue 7) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 8) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT
(In reply to Joy Nelson from comment #1) > Along these same lines, it would be great to be able to use the batch > modification (or other method) to add a batch of bib/items to a list. I have added a patch for this suggestion to Bug 18127
Aleisha Looks good. But please note that a list only contains biblio records. So you should not offer the option when the user selects Authorities.
Created attachment 60362 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the list from the dropdown and click Continue 8) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 9) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT
Created attachment 60367 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT
Created attachment 60489 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Aleisha, 2 small things here: 1. Go on Home › Tools › Batch record modification Select a list Select "authorities" Fill the textarea with authid Next => Id from list is picked 2. I think we should raise a warning (JS side) if 2 sources of ids are filled: * For biblios: file and list or file and ids or list and ids * For authorities: file and ids (list should not be taken into account even if filled)
(In reply to Jonathan Druart from comment #8) > Aleisha, > 2 small things here: > 1. Go on Home › Tools › Batch record modification > Select a list > Select "authorities" > Fill the textarea with authid > Next > => Id from list is picked I don't understand this... if you select authorities, the option to add biblios from a shelf is hidden by JS. > 2. I think we should raise a warning (JS side) if 2 sources of ids are > filled: > * For biblios: file and list or file and ids or list and ids > * For authorities: file and ids (list should not be taken into account even > if filled) That seems slightly out of the scope of this bug. I am happy to make a new patch for this on a separate bug, but it doesn't stop this patch from working.
(In reply to Aleisha Amohia from comment #9) > (In reply to Jonathan Druart from comment #8) > > Aleisha, > > 2 small things here: > > 1. Go on Home › Tools › Batch record modification > > Select a list > > Select "authorities" > > Fill the textarea with authid > > Next > > => Id from list is picked > > I don't understand this... if you select authorities, the option to add > biblios from a shelf is hidden by JS. Yes it's hidden but it's taken into account. > > 2. I think we should raise a warning (JS side) if 2 sources of ids are > > filled: > > * For biblios: file and list or file and ids or list and ids > > * For authorities: file and ids (list should not be taken into account even > > if filled) > > That seems slightly out of the scope of this bug. I am happy to make a new > patch for this on a separate bug, but it doesn't stop this patch from > working. I would not pass QA it without that change, but maybe something else will...
Patch tested with a sandbox, by EricGosselin <eric.gosselin@inLibro.com>
Created attachment 61337 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: EricGosselin <eric.gosselin@inLibro.com>
As I said previously I am not willing to PQA this one as it (because of the lack of JS checks). However the patch looks wrong, all lists are listed (even the private ones) and the "Or select a list of records" block is display even if there are no list defined.
Would it make sense to completely reset the form if someone selects a different input method (file/list/numbers) ? http://zivotdesign.com/p/#1/15239764835671
(In reply to Owen Leonard from comment #14) > Would it make sense to completely reset the form if someone selects a > different input method (file/list/numbers) ? > > http://zivotdesign.com/p/#1/15239764835671 why not tabs then?
(In reply to Jonathan Druart from comment #15) > why not tabs then? Tabs work too. But is it going to make someone mad if they paste a list of barcodes, switch tabs, switch back, and find their input gone?
I think tabs. Could we keep the content or is that not possible?
(In reply to Katrin Fischer from comment #17) > I think tabs. Could we keep the content or is that not possible? Hi Katrin, When I read Jeremy's first comment, he talks about Batch items modification/deletion. I understand that patch proposed by Aleisha concerns only thr tool for batch record modification/deletion. Do I need to open a new bug for tool "batch items modification"? Regards, Marjorie
Hi Marjorie, thx for updating! I think then instead of displaying an option to send to the batch item edit or download option for a list of itemnumbers could also work.
(In reply to Katrin Fischer from comment #19) > Hi Marjorie, thx for updating! I think then instead of displaying an option > to send to the batch item edit or download option for a list of itemnumbers > could also work. Hi Katrin, Yes your idea is great. I guess it's better then to open a new bug report? Marjorie
Yes, I think separate bug is best, clean start and this is about the record level, so both can be worked on independently.
Created attachment 75548 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT NOTE: Rebased to work -- Mark Tompsett
Created attachment 75572 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT NOTE: Rebased to work -- Mark Tompsett Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 10 and comment 13 are still valid... Moreover, prefer to pass an iterator to the template: -my @lists = Koha::Virtualshelves->search({}); -$template->param( lists => \@lists ); +$template->param( virtual_shelves => scalar Koha::Virtualshelves->search ); You will need to adapt the template accordingly ([% IF virtual_shelves.count %], etc.)
*** Bug 17273 has been marked as a duplicate of this bug. ***
Created attachment 76802 [details] [review] Bug 12759: [FOLLOW-UP] Using tabs for diff ways of adding records This patch includes the changes for both batch record modification and deletion. Checks that all public lists are included and only private lists created by the logged in user. Hides the virtualshelves option if authorities are selected.
Created attachment 76803 [details] [review] Bug 12759: [FOLLOW-UP] Using tabs for diff ways of adding records This patch includes the changes for both batch record modification and deletion. Checks that all public lists are included and only private lists created by the logged in user. Hides the virtualshelves option if authorities are selected. Doesn't show shelf option at all if none exist
Tested in Biblibre Sandbox no. 2. Unable to select Authorities radio button under either Batch Record Modification or Deletion tool. No problems deleting records, or modifying/ adding content to a MARC field appearing in the editor, using a list as a source of records. Perhaps unrelated, but was unable to add content to a field that was not visible in the MARC editor (e.g., 945, 970).
Took a look at this one too. I think the intended behaviour is that when you check the authorities checkbox, the list option is not offered as the lists can only contain bibliographic records. That does work ok when you start at the top, but when you've already switched to the list tab and then switch from bibliographic to authority, your conf remains visible. Maybe needs a little tweaking.
(second patch contains .nfs* files that should not have been committed)
(In reply to Katrin Fischer from comment #29) > Took a look at this one too. I think the intended behaviour is that when you > check the authorities checkbox, the list option is not offered as the lists > can only contain bibliographic records. That does work ok when you start at > the top, but when you've already switched to the list tab and then switch > from bibliographic to authority, your conf remains visible. Maybe needs a > little tweaking. Hi Katrin, I've spent a lot of time playing with different methods as specified here: https://api.jqueryui.com/tabs/ but haven't had any success in fixing this toggle issue. Do you have any tips or ideas?
Created attachment 82228 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT NOTE: Rebased to work -- Mark Tompsett Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 82229 [details] [review] Bug 12759: (follow-up) Using tabs for diff ways of adding records This patch includes the changes for both batch record modification and deletion. Checks that all public lists are included and only private lists created by the logged in user. Hides the virtualshelves option if authorities are selected. Doesn't show shelf option at all if none exist
Created attachment 82230 [details] [review] Bug 12759: Pass records from selected tab To remove ambiguity we should not process the records from other tabs.
Hi Jonathan The patch works but we are still having the issue that Katrin pointed out in Comment 29. The tab hides when you change to Authorities, but if you are on that tab when you change, the content underneath it stays visible. I couldn't work out a way to change to a different tab when changing from Biblios to Authorities and I think that would be the best fix.
Aleisha, With the last patch I do not think it is longer a problem. On the contrary it may be better to not empty the inputs when tabs change (it is the same behavior we have in the header). Switching back to NSO to get other opinions.
Created attachment 83421 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT NOTE: Rebased to work -- Mark Tompsett Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 83422 [details] [review] Bug 12759: (follow-up) Using tabs for diff ways of adding records This patch includes the changes for both batch record modification and deletion. Checks that all public lists are included and only private lists created by the logged in user. Hides the virtualshelves option if authorities are selected. Doesn't show shelf option at all if none exist Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 83423 [details] [review] Bug 12759: Pass records from selected tab To remove ambiguity we should not process the records from other tabs. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 83424 [details] [review] bug 12759: Add missing html filters Add some missing html filters to fix QA script complaints. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hi Aleisha, please make sure you run the latest version of the QA tools on your patches. There are some missing filters: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt FAIL filters missing_filter at line 98 ( <option value="[% list.shelfnumber %]">[% list.shelfname %]</option>) OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt FAIL filters missing_filter at line 102 ( <option value="[% list.shelfnumber %]">[% list.shelfname %]</option>) Bug 21576 can be helpful to fix those. Fixed them in a follow-up :)
Created attachment 84672 [details] [review] Bug 12759: Add missing html filters Add some missing html filters to fix QA script complaints. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Just fixed my own typo on the follow-up patch's commit message. Can't QA as I signed off.
Created attachment 84875 [details] [review] Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT NOTE: Rebased to work -- Mark Tompsett Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 84876 [details] [review] Bug 12759: (follow-up) Using tabs for diff ways of adding records This patch includes the changes for both batch record modification and deletion. Checks that all public lists are included and only private lists created by the logged in user. Hides the virtualshelves option if authorities are selected. Doesn't show shelf option at all if none exist Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 84877 [details] [review] Bug 12759: Pass records from selected tab To remove ambiguity we should not process the records from other tabs. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 84878 [details] [review] Bug 12759: Add missing html filters Add some missing html filters to fix QA script complaints. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
No regressions found and the QA scripts all pass. Seems to work well and is a nice little enhancment. Passing QA
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series.