Bug 12778 - Regression: Item lost status doesn't show in list of checkouts
Summary: Regression: Item lost status doesn't show in list of checkouts
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
: 10623 (view as bug list)
Depends on: 11703
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-17 18:54 UTC by Katrin Fischer
Modified: 2015-12-03 22:02 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 12778 - Regression: Item lost status doesn't show in list of checkouts (3.07 KB, patch)
2014-11-13 18:05 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 12778 - Regression: Item lost status doesn't show in list of checkouts (3.42 KB, patch)
2014-11-14 12:29 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts (3.58 KB, patch)
2014-11-14 13:05 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts (3.63 KB, patch)
2014-11-15 08:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-08-17 18:54:47 UTC
When using the longoverdue script it's possible that items marked lost remain on the patron account. I think it's important for staff to see that some items are marked lost - currently the list of checkouts doesn't show any sign of the lost status.
Comment 1 Katrin Fischer 2014-11-02 11:14:54 UTC
*** Bug 10623 has been marked as a duplicate of this bug. ***
Comment 2 Owen Leonard 2014-11-04 13:40:01 UTC
This is a regression caused by Bug 11703
Comment 3 Kyle M Hall (khall) 2014-11-13 18:05:43 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2014-11-14 02:14:28 UTC
Only the lost status should display. "Available" should not display for items which are not lost.

Checking out 3.14.x and looking at the way it used to look is helpful. I notice that in 3.14.x the damaged status of items also appeared in that column the same way the lost status did.
Comment 5 Kyle M Hall (khall) 2014-11-14 12:19:54 UTC
(In reply to Owen Leonard from comment #4)
> Only the lost status should display. "Available" should not display for
> items which are not lost.
> 
> Checking out 3.14.x and looking at the way it used to look is helpful. I
> notice that in 3.14.x the damaged status of items also appeared in that
> column the same way the lost status did.

I didn't take into account the possibility that the description for lost value 0 would be filled in ( it's not in the default data ). I will correct that and see if I can't do the same for the damaged status.
Comment 6 Kyle M Hall (khall) 2014-11-14 12:29:10 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2014-11-14 13:05:35 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2014-11-15 08:39:08 UTC
Created attachment 33587 [details] [review]
[PASSED QA] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts

When using the longoverdue script it's possible that items marked lost
remain on the patron account. I think it's important for staff to see
that some items are marked lost - currently the list of checkouts
doesn't show any sign of the lost status.

Test Plan:
1) Find a patron with a checked out lost item
2) Note the lost status is not displayed in the checkouts table
3) Apply this patch
4) Refresh the page, note the lost status now displays
5) Repeat this test plan for a damaged item

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested successfully with damaged and multiple lost values.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Comment 9 Tomás Cohen Arazi (tcohen) 2014-11-17 00:22:56 UTC
Patch pushed to master.

Thanks Kyle!
Comment 10 Mason James 2015-01-19 13:28:26 UTC
Pushed to 3.16.x, will be in 3.16.7