Bug 12790 - Perl modules: Display required version numbers on about page
Summary: Perl modules: Display required version numbers on about page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marc Véron
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-20 06:30 UTC by Marc Véron
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12790 - Perl modules: Display required version numbers on about page (1.76 KB, patch)
2014-08-20 06:44 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12790 - Perl modules: Display required version numbers on about page (1.83 KB, patch)
2014-09-03 03:47 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 12790 - Perl modules: Display required version numbers on about page (1.85 KB, patch)
2014-09-03 15:27 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12790 - Perl modules: Display required version numbers on about page (1.92 KB, patch)
2014-09-03 15:42 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12790: QA-follow-up: Mention required version in online Help (1.31 KB, patch)
2014-09-04 06:48 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 12790 - Perl modules: Display required version numbers on about page (1.99 KB, patch)
2014-09-04 06:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 12790: QA-follow-up: Mention required version in online Help (1.31 KB, patch)
2014-09-04 06:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2014-08-20 06:30:48 UTC
On 'About' page, tab 'Perl modules' displays the installed version numbers, but not the required ones.
Comment 1 Marc Véron 2014-08-20 06:44:54 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2014-09-03 03:47:12 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-09-03 12:01:10 UTC
Hi Marc,
The patch applies. But imo the display does not improve with this patch. This may be an arbitrary design issue...

But could you display it somewhat differently? Less confusing?
BTW Is it really necessary to show the required version if you have an installed version that is equal or higher?

Hope that you could find a way to improve the display.
Comment 4 Marc Véron 2014-09-03 14:43:12 UTC
I submitted this patch because of Bug 5599 (it says that Perl dependencies are not compared correctly, e.g. 1.3.12 would be greater than 1.3.5).
Comment 5 Marc Véron 2014-09-03 15:27:15 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2014-09-03 15:42:19 UTC Comment hidden (obsolete)
Comment 7 Marcel de Rooy 2014-09-04 06:48:45 UTC Comment hidden (obsolete)
Comment 8 Marcel de Rooy 2014-09-04 06:49:00 UTC
Created attachment 31360 [details] [review]
Bug 12790 - Perl modules: Display required version numbers on about page

This patch adds information about required perl module versions to the
'About' page.

To test:
Apply patch.
In staff client, go to 'About', tab 'Perl modules'
The required version numbers should display in small print next to or
underneath the module names.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2014-09-04 06:49:04 UTC
Created attachment 31361 [details] [review]
Bug 12790: QA-follow-up: Mention required version in online Help

For those who would not understand the two version numbers and come up
with the idea to check the Help page, some text is added.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Marcel de Rooy 2014-09-04 06:54:05 UTC
QA Comment:
Since the code change is minimal, the signoff of Nick still holds.
I saw the About page on a wider screen now, and it looks good.
If you make the window smaller, it still does not look nice.

Looking at the template code (not your added lines only), it seems that this could be simplified. For instance, a check on the module name does not really make sense. If there is no module name, there should be no row.
Furthermore, the template contains several style attrs which probably should be moved to css.

Imo the display still needs improvement for a smaller screen, but I will not block this patch for that reason.

Passed QA
Comment 11 Tomás Cohen Arazi 2014-09-05 14:39:25 UTC
Patches pushed to master.

Thanks Marc!

Note: i belive the layout should be made cleaner to read, but am happy someone is taking care of end-users :-D