Bug 12810 - After MTT gather_print_notices includes overdues
Summary: After MTT gather_print_notices includes overdues
Status: RESOLVED DUPLICATE of bug 11678
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: 3.16
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 11603
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-22 21:09 UTC by Larry Baerveldt
Modified: 2015-06-07 00:12 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Larry Baerveldt 2014-08-22 21:09:38 UTC
After the inclusion of MTT in 3.16, the gather_print_notices is no longer restricted to print holds notices; it now also includes the print overdues as well. I have not tested, but suspect it would now include any notice with transport type of 'print'.

There are a couple of options for dealing with this. 

1) If this is the new post-MTT *intended* behavior, then the documentation should be updated to reflect the broader coverage of gather_print_notices, and the output file should no longer start with 'holdnotices-', but should be something more generic, e.g. 'notices-'. Optionally, could modify cronjob to split notices into files reflecting their type, e.g. 'holdnotices-', 'overduenotices-', 'preduenotices-', etc.

2) Revert the script back to only dealing with holds notices. 


There are currently bugs in place to address the issue of print overdues no longer being emailed to the library, as well as a bug to allow gather_print_notices to email the output file. This bug fix should take work on those bugs into consideration.

- Larry
Comment 1 Larry Baerveldt 2014-08-27 16:46:15 UTC
It appears that Bug 11603 will be adding the option to specify letter_code in gather_print_notices. If that patch is pushed, then this bug becomes irrelevant.

- Larry
Comment 2 Christopher Brannon 2014-11-25 18:04:08 UTC
Since this looks like this feature rather than a bug, should the generated file be renamed?  Right now, our files read "holdnotices-2014-11-07.html".  Perhaps they should read "printednotices-2014-11-07.html".
Comment 3 Christopher Brannon 2014-11-25 20:00:52 UTC
By the way, I am starting to like the ability to have access to printed overdues and holds.  Whether we keep them in the same file, or separate them, I like the access.

Christopher
Comment 4 Katrin Fischer 2014-11-25 20:02:38 UTC
Hi Christopher, we are looking for sign-offs for bug 11678 and 11603 that are related to this job - I think they might resolve some of the issues noted here.
Comment 5 Christopher Brannon 2014-11-25 20:06:23 UTC
(In reply to Katrin Fischer from comment #4)
> Hi Christopher, we are looking for sign-offs for bug 11678 and 11603 that
> are related to this job - I think they might resolve some of the issues
> noted here.

I'm not quite at the point where I can test these yet.  Almost, but still working some details out on my Virtual box.
Comment 6 Katrin Fischer 2015-06-07 00:12:33 UTC
1) is done by bug 11678 - marking this duplicate. Please open a new bug if we are still missing needed functionality.

*** This bug has been marked as a duplicate of bug 11678 ***