This report deals with a specific QA remark on point 6536 ("Database field not obvious for SRU servers"). Since this could be done in various ways, I prefer to put it under a separate report.
Created attachment 31154 [details] [review] Bug 12823: Add some hints for Host and Database when hovering their labels When adding or editing a SRU server, the red Required text will be appended with another hint how to fill these fields. Test plan: Add/Edit SRU server. Hover over the Hostname and Database label. Add/Edit Z39.50 server. Hover again. No additional text.
I am extending this report with QA remark 3 on bug 6536 (Hint to define the SRU search field mappings). The proposed path will warn a user that saves a SRU server without those mappings.
Created attachment 31155 [details] [review] Bug 12823: Hint to define the SRU search field mappings This is a follow report for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings.
Created attachment 31156 [details] [review] Bug 12823: Hint to define the SRU search field mappings This is a follow report for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z#9.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message.
Created attachment 31157 [details] [review] Bug 12823: Hint to define the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message.
Follow-up coming for qa tools warnings.
Created attachment 31228 [details] [review] Bug 12823: Add some hints for Host and Database when hovering their labels When adding or editing a SRU server, the red Required text will be appended with another hint how to fill these fields. Test plan: Add/Edit SRU server. Hover over the Hostname and Database label. Add/Edit Z39.50 server. Hover again. No additional text.
Created attachment 31229 [details] [review] Bug 12823: Hint to define the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message.
(In reply to M. de Rooy from comment #6) > Follow-up coming for qa tools warnings. Resolved.
I think a more standard and more usable solution for the hints would be to use <div class="hint"></div>. See memberentrygen.tt for an example.
Created attachment 33981 [details] [review] Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options.
Created attachment 33982 [details] [review] Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message.
(In reply to Owen Leonard from comment #10) > I think a more standard and more usable solution for the hints would be to > use <div class="hint"></div>. See memberentrygen.tt for an example. Thanks for your feedback. Simplified the patch.
Created attachment 34690 [details] [review] [SIGNED OFF] Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options. Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 34691 [details] [review] [SIGNED OFF] Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 34695 [details] [review] [PASSED QA] Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 34696 [details] [review] [PASSED QA] Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Marcel!
Pushed to 3.18.x will be in 3.18.3
Pushed to 3.16.x, will be in 3.16.7
(In reply to Mason James from comment #20) > Pushed to 3.16.x, will be in 3.16.7 Oops, I accidentally introduced a merge bug in the .tt file, with this patchset I'm going to revert this for the 3.16.8 release