... and can be removed.
Created attachment 31261 [details] [review] Bug 12845: C4::Output::FormatData can be removed Test plan: git grep FormatData should not return any result in pl and pm files.
I am still getting one result: nick@debian:~/koha$ git grep FormatData C4/Output.pm: &output_html_with_http_headers &output_ajax_with_http_headers &output_with_http_headers FormatData FormatNumber
Created attachment 31332 [details] [review] Bug 12845: C4::Output::FormatData can be removed Test plan: git grep FormatData should not return any result in pl and pm files.
(In reply to Nick Clemens from comment #2) > I am still getting one result: Oops :) Fixed in the last patch.
Created attachment 31334 [details] [review] [SIGNED OFF] Bug 12845: C4::Output::FormatData can be removed Test plan: git grep FormatData should not return any result in pl and pm files. Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Sorry, looked at wrong bug for signoff, will retest and sign off asap
Created attachment 31336 [details] [review] [SIGNED OFF] Bug 12845: C4::Output::FormatData can be removed Test plan: git grep FormatData should not return any result in pl and pm files. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> nick@debian:~/koha$ git grep FormatData C4/Output.pm: &output_html_with_http_headers &output_ajax_with_http_headers &output_with_http_headers FormatData FormatNumber C4/Output.pm:=item FormatData C4/Output.pm:FormatData($data_hashref) C4/Output.pm:sub FormatData{ nick@debian:~/koha$ git bz apply 12845 Bug 12845 - C4::Output::FormatData is unused 31332 - Bug 12845: C4::Output::FormatData can be removed Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12845: C4::Output::FormatData can be removed nick@debian:~/koha$ git bz apply 12845 Bug 12845 - C4::Output::FormatData is unused 31332 - Bug 12845: C4::Output::FormatData can be removed Apply? [(y)es, (n)o, (i)nteractive] n nick@debian:~/koha$ git grep FormatData nick@debian:~/koha$
Created attachment 31345 [details] [review] Bug 12845: C4::Output::FormatData can be removed Test plan: git grep FormatData should not return any result in pl and pm files. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 35289 [details] [review] Bug 12845: C4::Output::FormatData can be removed Test plan: git grep FormatData should not return any result in pl and pm files. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Patch pushed to master. Thanks Jonathan!