12850 – C4::Serials::GetLateIssues is not used

Bug 12850 - C4::Serials::GetLateIssues is not used

Summary: C4::Serials::GetLateIssues is not used

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Jonathan Druart
QA Contact:	Marcel de Rooy

URL:
Keywords:

Depends on:
Blocks:

Reported:	2014-08-29 10:50 UTC by Jonathan Druart
Modified:	2021-03-02 11:13 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12850: C4::Serials::GetLateIssues can be removed (4.22 KB, patch) 2014-08-29 10:54 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
[SIGNED OFF] Bug 12850: C4::Serials::GetLateIssues can be removed (4.29 KB, patch) 2014-09-03 03:20 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Bug 12850: C4::Serials::GetLateIssues can be removed (4.36 KB, patch) 2014-09-03 14:15 UTC, Marcel de Rooy	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2014-08-29 10:50:54 UTC

... and can be removed.

Comment 1 Jonathan Druart 2014-08-29 10:54:09 UTC Comment hidden (obsolete)

Created attachment 31274 [details] [review]
Bug 12850: C4::Serials::GetLateIssues can be removed

This routine is not used and can be removed.

Test plan:
  git grep GetLateIssues
should not return any result

Comment 2 Nick Clemens (kidclamp) 2014-09-03 03:20:24 UTC Comment hidden (obsolete)

Created attachment 31329 [details] [review]
[SIGNED OFF] Bug 12850: C4::Serials::GetLateIssues can be removed

This routine is not used and can be removed.

Test plan:
  git grep GetLateIssues
should not return any result

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Switched to a new branch 'bug_12850'
nick@debian:~/koha$ git grep GetLateIssues
C4/Serials.pm:      &ReNewSubscription  &GetLateIssues      &GetLateOrMissingIss
C4/Serials.pm:=head2 GetLateIssues
C4/Serials.pm:@issuelist = GetLateIssues($supplierid)
C4/Serials.pm:sub GetLateIssues {
t/db_dependent/Serials.t:is(C4::Serials::GetLateIssues(), undef, 'test getting l
nick@debian:~/koha$ git bz apply 12850
Bug 12850 - C4::Serials::GetLateIssues is not used

31274 - Bug 12850: C4::Serials::GetLateIssues can be removed

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12850: C4::Serials::GetLateIssues can be removed
nick@debian:~/koha$ git grep GetLateIssues
nick@debian:~/koha$

Comment 3 Marcel de Rooy 2014-09-03 14:15:07 UTC

Created attachment 31346 [details] [review]
Bug 12850: C4::Serials::GetLateIssues can be removed

This routine is not used and can be removed.

Test plan:
  git grep GetLateIssues
should not return any result

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Tomás Cohen Arazi (tcohen) 2015-01-15 00:40:50 UTC

Patch pushed to master.

Thanks Jonathan!