If you hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY You will see a lot of this opac-authorities-home.pl: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 146, <DATA> line 522. In the error logs
Created attachment 31324 [details] [review] Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- else { # Assume any if no index was specified - $attr = " \@attr 1=Any "; - } From glancing thru this code: The place of this else in the old code and in the new code is different. In the new code you are not reaching this point anymore.
Created attachment 32782 [details] [review] Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 35304 [details] [review] Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Instead of 10 warnings, I now have only 4 warnings. We're going in the right direction.
opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 172. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 176. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 179. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 183.
Created attachment 35308 [details] [review] Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns.
Could I get a signoff on the second patch please?
Created attachment 35360 [details] [review] Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 35364 [details] [review] Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Instead of 10 warnings, I now have only 4 warnings. We're going in the right direction. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 35365 [details] [review] Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patches pushed to master. Thanks Chris and Jonathan!
Pushed to 3.18.x will be in 3.18.4
(In reply to Chris Cormack from comment #12) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8