We have come across a possible bug or issue with the note boxes in the pay fines tab on the staff clients. Here is a a few test cases to understand the issue. This test case works for single line payments. 1. Clear all check boxes and select the check box of the fine you would like to pay. Add a note and select the Pay Selected box. (see image Paymentbox1) 2. You should be in the confirmation screen and the note text should be brought over. (see Paymentbox2) 3. Hit the confirm button and the note now displays in the notes fields. (see Paymentbox3) This test case does not work. 1. Select the Pay Amount button, change and add a note in the note box. (see Paymentbox4) 2. Select confirm and the note does not display. The work around test case. 1. Select the check boxes of the fines the are choosing to pay and select the Pay Selected button. 2. Add a note in the notes box and select confirm. 3. The note displays.
I followed the test cases and can confirm the behaviour. If I put a note in paycollet.pl: "Pay an amount toward all fines", it does not display.
Created attachment 31545 [details] [review] Bug 12865 - 'Pay amount toward all fines' does not record payment note Without patch: ------------- Make payment for patron who has fines Select the Pay Amount button and add a note in the note box. Select confirm Result: The note does not display in list With patch: ---------- Result: The note displays in list Bonus testing: The note is included in system logs as well (Home:Tools:Logs)
Original version was 3.14. Version set to master. Setting priority to P3 because data is not properly recorded in database.
Created attachment 31546 [details] [review] [SIGNED-OFF] Bug 12865 - 'Pay amount toward all fines' does not record payment note Without patch: ------------- Make payment for patron who has fines Select the Pay Amount button and add a note in the note box. Select confirm Result: The note does not display in list With patch: ---------- Result: The note displays in list Bonus testing: The note is included in system logs as well (Home:Tools:Logs) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Marc Véron from comment #3) > Setting priority to P3 because data is not properly recorded in database. By the way, as far as I know priority settings are not taken into account in the QA process. I think changing the severity (minor/normal/major/etc) is preferred.
Created attachment 31554 [details] [review] [PASSED QA] Bug 12865 - 'Pay amount toward all fines' does not record payment note Without patch: ------------- Make payment for patron who has fines Select the Pay Amount button and add a note in the note box. Select confirm Result: The note does not display in list With patch: ---------- Result: The note displays in list Bonus testing: The note is included in system logs as well (Home:Tools:Logs) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
*** Bug 12314 has been marked as a duplicate of this bug. ***
Patch pushed to master. Thanks Marc!