For example, the following URL in 856$u: http://www.mrqe.com/lookup?talented+mr.+ripley will trigger the following error: Quantifier follows nothing in regex; marked by <-- HERE in m/+ <-- HERE ripley/ at /var/lib/koha/coos/kohaclone/C4/HTML5Media.pm line 113. This will make all searches where the record in question is in the results impossible. You will get the error instead of search results.
Created attachment 41009 [details] [review] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled The special regex chars are not escaped in C4::HTML5Media. Test plan: 1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley 2/ Enable the pref HTML5Media 3/ Go on the detail page It should not explode.
Created attachment 41210 [details] [review] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled The special regex chars are not escaped in C4::HTML5Media. Test plan: 1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley 2/ Enable the pref HTML5Media 3/ Go on the detail page It should not explode. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 41523 [details] [review] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled Error disappears and code looks good to me. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 42182 [details] [review] [PASSED QA] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled The special regex chars are not escaped in C4::HTML5Media. Test plan: 1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley 2/ Enable the pref HTML5Media 3/ Go on the detail page It should not explode. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.20.x will be in 3.20.4
Pushed to 3.18.x will be in 3.18.11.