Bug 12890 - Improve title and breadcrumbs when editing saved SQL report
Summary: Improve title and breadcrumbs when editing saved SQL report
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-08 18:15 UTC by Owen Leonard
Modified: 2015-06-04 23:32 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12890 - Improve title and breadcrumbs when editing saved SQL report (2.17 KB, patch)
2014-09-08 18:24 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 12890 - Improve title and breadcrumbs when editing saved SQL report (2.31 KB, patch)
2014-09-13 13:03 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12890 - Improve title and breadcrumbs when editing saved SQL report (2.36 KB, patch)
2014-09-16 13:19 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-09-08 18:15:00 UTC
When you edit an SQL report the template doesn't show a complete title or breadcrumbs menu.
Comment 1 Owen Leonard 2014-09-08 18:24:16 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-09-10 15:13:31 UTC
Aleisha, did you test this patch?
It seems you forgot to attach your signoff patch.
Comment 3 Marc Véron 2014-09-13 13:03:00 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-09-16 13:19:14 UTC
Created attachment 31629 [details] [review]
Bug 12890 - Improve title and breadcrumbs when editing saved SQL report

When editing an existing SQL report the page title and breadcrumbs are
incomplete:

Home > Reports > Guided reports wizard >

This patch corrects this.

To test, apply the patch and edit an existing SQL report. The page title
and breadcrumbs should be more complete:

Home > Reports > Guided reports wizard > Saved reports > Edit SQL report

Patch behves as expected
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Tomás Cohen Arazi 2014-09-18 01:10:03 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 6 Tomás Cohen Arazi 2014-09-18 01:11:22 UTC
Heh, wrong bug, thanks Owen :-D