In checkouts.js the checkouts table is being built and the rows are grouped ascending alphabetically into "Today's checkouts" and "Previous checkouts". The problem is that in translations where the words are different sorting "asc" can change the layout so that previous checkouts are on top and hides todays. Very impractical. .rowGrouping is the culprit. Thanks to Owen and Kyle for troubleshooting.
Created attachment 31502 [details] [review] Bug 12899 - Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly.
Created attachment 31511 [details] [review] Bug 12899 - Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
If the export column is displayed (I didn't try without this column), the columns are misplaced. Instead of adding a new column, what about a "<span title=''></span>", it does not work?
Created attachment 31599 [details] [review] Bug 12899 [Revised] Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Revision: Corrected the table footer include to correct the colspan error causing column misalignment.
Created attachment 31620 [details] [review] Bug 12899 [Revised] Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Revision: Corrected the table footer include to correct the colspan error causing column misalignment. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 31621 [details] [review] Bug 12899: Row grouping in checkouts table is alphabetical and depends on translation The sort order of the "today's checkouts" and "previous checkouts" row groupings depends on the label, so in English "today's checkouts" comes first. However, in other languages the reverse alphabetical order is incorrect resulting in "previous checkouts" coming first. This patch adds a dummy column with numeric data on which the sorting can be done. This should make it translation-agnostic. To test, apply the patch and install or update a translation which will demostrate the problem (sv-SE for instance). - Clear your browser cache and switch to the English templates. - Check out some items to a patron who has checkouts from a previous day. - Confirm that the sorting of the "today's checkouts" and "previous checkouts" row groups is correct. - Switch to the new/updated translation and reload the circulation page for that patron. Confirm that the sort remains correct. - Confirm that the checkouts table looks correct and that other features (sorting, checkboxes) still work correctly. Revision: Corrected the table footer include to correct the colspan error causing column misalignment. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Owen!
Pushed to 3.16.x for inclusion in 3.16.4.