Bug 12918 - Error in test case causes test failure
Summary: Error in test case causes test failure
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P4 normal
Assignee: Robin Sheat
QA Contact: Galen Charlton
URL:
Keywords:
Depends on: 12716
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-15 02:07 UTC by Robin Sheat
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12918 - fix failing test case (996 bytes, patch)
2014-09-15 02:10 UTC, Robin Sheat 		Details | Diff | Splinter Review
Bug 12918 - fix failing test case (1.21 KB, patch)
2014-09-15 03:59 UTC, Robin Sheat 		Details | Diff | Splinter Review
Bug 12918 - fix failing test case (1.33 KB, patch)
2014-09-15 12:45 UTC, Mark Tompsett 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12918: fix failing test case (1.53 KB, patch)
2014-09-15 13:07 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
[PASSED QA] Bug 12918: fix failing test case (1.59 KB, patch)
2014-09-15 13:22 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2014-09-15 02:07:33 UTC 
Bug 12716 introduced a bug that causes build failure on older Perl, and a warning on newer Perl.
Comment 1 Robin Sheat 2014-09-15 02:10:51 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2014-09-15 03:59:53 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2014-09-15 12:45:30 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi (tcohen) 2014-09-15 13:07:03 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall (khall) 2014-09-15 13:22:25 UTC 
Created attachment 31609 [details] [review]
[PASSED QA] Bug 12918: fix failing test case

A bug in a test case causes test case failure. It also required a
database, so I'm moving it out of the way.

Test plan:
1) prove -v t/db_dependent/Templates.t
   -- bombs!
2) apply patch
3) prove -v t/db_dependent/Templates.t
   -- works!

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Mark Tompsett 2014-09-15 13:48:34 UTC 
BTW, it fails in 5.14 which is Ubuntu 12.04 LTS default. ;)
Comment 7 Tomás Cohen Arazi (tcohen) 2014-09-17 23:11:40 UTC 
Patch pushed to master.

Thanks Robin!