Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead
Summary: Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 12811
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-15 11:26 UTC by Kyle M Hall
Modified: 2017-01-10 19:36 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead (4.01 KB, patch)
2014-09-15 11:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead (3.80 KB, patch)
2016-01-19 00:59 UTC, natasha
Details | Diff | Splinter Review
Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead (3.89 KB, patch)
2016-01-20 12:15 UTC, Kyle M Hall
Details | Diff | Splinter Review
bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead (3.84 KB, patch)
2016-01-20 12:17 UTC, Kyle M Hall
Details | Diff | Splinter Review
bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead (3.85 KB, patch)
2016-02-03 16:11 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12920 [QA Followup] - Show override option below checkouts table when allowed (1.38 KB, patch)
2016-02-03 16:11 UTC, Kyle M Hall
Details | Diff | Splinter Review
bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead (3.92 KB, patch)
2016-02-09 10:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12920 [QA Followup] - Show override option below checkouts table when allowed (1.45 KB, patch)
2016-02-09 10:59 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-09-15 11:26:23 UTC
Per the new guidelines, AllowRenewalLimitOverride should not be referenced in circulation.pl or moremember.pl
Comment 1 Kyle M Hall 2014-09-15 11:29:14 UTC Comment hidden (obsolete)
Comment 2 Jacek Ablewicz 2014-09-15 12:56:33 UTC
(In reply to Kyle M Hall from comment #1)

> Test Plan:
> 1) Apply this patch
> 2) Go to circulation.pl
> 3) Ensure you can still override renewal limits with pref enabled

"Override renewal limit:" checkbox does not show, even if the syspref is enabled and the user has permision for renewal override. Looks like the AllowRenewalLimitOverride template variable is/was used two times in both templates, but only the 1st occurence[s] got coverted to Koha.Preference() call (?).
Comment 3 Owen Leonard 2014-10-10 18:53:06 UTC
(In reply to Jacek Ablewicz from comment #2)
> "Override renewal limit:" checkbox does not show, even if the syspref is
> enabled and the user has permision for renewal override.

Confirmed.
Comment 4 Chris Cormack 2016-01-18 23:34:52 UTC
Students are working on this
Comment 5 natasha 2016-01-19 00:59:18 UTC Comment hidden (obsolete)
Comment 6 natasha 2016-01-19 01:01:28 UTC
Original patch did not apply 
fatal: sha1 information is lacking or useless (circ/circulation.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead
Comment 7 Kyle M Hall 2016-01-19 13:53:23 UTC
(In reply to natasha from comment #6)
> Original patch did not apply 
> fatal: sha1 information is lacking or useless (circ/circulation.pl).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl
> scripts, use Koha.Preference instead

I'm having no trouble applying this patch to the latest master. Can you try again?

Thanks!
Comment 8 Aleisha Amohia 2016-01-19 20:22:09 UTC
(In reply to Kyle M Hall from comment #7)
> (In reply to natasha from comment #6)
> > Original patch did not apply 
> > fatal: sha1 information is lacking or useless (circ/circulation.pl).
> > Repository lacks necessary blobs to fall back on 3-way merge.
> > Cannot fall back to three-way merge.
> > Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl
> > scripts, use Koha.Preference instead
> 
> I'm having no trouble applying this patch to the latest master. Can you try
> again?
> 
> Thanks!

I think she meant that your didn't apply, which is why she submitted her patch and obseleted the first one. This needs to be tested now but I can't test it.
Comment 9 Kyle M Hall 2016-01-20 12:15:37 UTC Comment hidden (obsolete)
Comment 10 Kyle M Hall 2016-01-20 12:17:18 UTC Comment hidden (obsolete)
Comment 11 Katrin Fischer 2016-01-20 22:24:05 UTC
I am sorry, but this patch doesn't seem to work for me:
- Activate system preference AllowRenewalLimitOverride (allow)
- Go to the checkouts and details tabs in the patron account
- There are items with max renewals reached, but the override function doesn't show below the table of loaded checkouts

Switching to master the checkbox is shown.

Could the problem be i koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js?
Comment 12 Kyle M Hall 2016-02-03 16:11:43 UTC Comment hidden (obsolete)
Comment 13 Kyle M Hall 2016-02-03 16:11:50 UTC Comment hidden (obsolete)
Comment 14 Jonathan Druart 2016-02-09 10:59:42 UTC
Created attachment 47789 [details] [review]
bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead

Test Plan:
1) Apply this patch
2) Go to circulation.pl
3) Ensure you can still override renewal limits with pref enabled
4) Ensure you can not override renewal limits with pref disabled
5) Go to moremember.pl
6) Repeat steps 3-4

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 15 Jonathan Druart 2016-02-09 10:59:46 UTC
Created attachment 47790 [details] [review]
Bug 12920 [QA Followup] - Show override option below checkouts table when allowed

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 16 Brendan Gallagher 2016-02-24 03:23:46 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 17 Julian Maurice 2016-03-07 13:19:38 UTC
Patch pushed to 3.22.x, will be in 3.22.5