Per the new guidelines, AllowRenewalLimitOverride should not be referenced in circulation.pl or moremember.pl
Created attachment 31596 [details] [review] Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead Per the new guidelines, AllowRenewalLimitOverride should not be referenced in circulation.pl or moremember.pl Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4
(In reply to Kyle M Hall from comment #1) > Test Plan: > 1) Apply this patch > 2) Go to circulation.pl > 3) Ensure you can still override renewal limits with pref enabled "Override renewal limit:" checkbox does not show, even if the syspref is enabled and the user has permision for renewal override. Looks like the AllowRenewalLimitOverride template variable is/was used two times in both templates, but only the 1st occurence[s] got coverted to Koha.Preference() call (?).
(In reply to Jacek Ablewicz from comment #2) > "Override renewal limit:" checkbox does not show, even if the syspref is > enabled and the user has permision for renewal override. Confirmed.
Students are working on this
Created attachment 46835 [details] [review] bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4
Original patch did not apply fatal: sha1 information is lacking or useless (circ/circulation.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead
(In reply to natasha from comment #6) > Original patch did not apply > fatal: sha1 information is lacking or useless (circ/circulation.pl). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl > scripts, use Koha.Preference instead I'm having no trouble applying this patch to the latest master. Can you try again? Thanks!
(In reply to Kyle M Hall from comment #7) > (In reply to natasha from comment #6) > > Original patch did not apply > > fatal: sha1 information is lacking or useless (circ/circulation.pl). > > Repository lacks necessary blobs to fall back on 3-way merge. > > Cannot fall back to three-way merge. > > Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl > > scripts, use Koha.Preference instead > > I'm having no trouble applying this patch to the latest master. Can you try > again? > > Thanks! I think she meant that your didn't apply, which is why she submitted her patch and obseleted the first one. This needs to be tested now but I can't test it.
Created attachment 46991 [details] [review] Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead Per the new guidelines, AllowRenewalLimitOverride should not be referenced in circulation.pl or moremember.pl Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4
Created attachment 46992 [details] [review] bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I am sorry, but this patch doesn't seem to work for me: - Activate system preference AllowRenewalLimitOverride (allow) - Go to the checkouts and details tabs in the patron account - There are items with max renewals reached, but the override function doesn't show below the table of loaded checkouts Switching to master the checkbox is shown. Could the problem be i koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js?
Created attachment 47604 [details] [review] bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 47605 [details] [review] Bug 12920 [QA Followup] - Show override option below checkouts table when allowed
Created attachment 47789 [details] [review] bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 47790 [details] [review] Bug 12920 [QA Followup] - Show override option below checkouts table when allowed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.5