Bug 12927 - Problems with item information tab on acq order from staged page
Summary: Problems with item information tab on acq order from staged page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
: 13008 (view as bug list)
Depends on: 12673
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-16 09:20 UTC by Katrin Fischer
Modified: 2015-07-15 11:29 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12927: Problems with item information tab on acq order from staged page (2.65 KB, patch)
2014-09-16 17:57 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12927: Problems with item information tab on acq order from staged page (2.77 KB, patch)
2014-09-29 12:48 UTC, Paola Rossi
Details | Diff | Splinter Review
Bug 12927: Problems with item information tab on acq order from staged page (2.77 KB, patch)
2014-09-29 15:04 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-09-16 09:20:24 UTC
Moving this to a new bug report, hope the title makes sense :)

To reproduce, go on acqui/addorderiso2709.pl?import_batch_id=3&basketno=7&booksellerid=5 (change ids), tab 'Item information'.
You will get:

b - Propriétaire HASH(0xd220cb0) Required
c - Dépositaire HASH(0xd44a3ec) Required
e - Localisation HASH(0xd44ab30) Required 

The dropdown list are replaced by the hashref address.
Comment 1 Bernardo Gonzalez Kriegel 2014-09-16 12:24:34 UTC
I'l fix this ASAP
Comment 2 Bernardo Gonzalez Kriegel 2014-09-16 17:57:57 UTC Comment hidden (obsolete)
Comment 3 Paola Rossi 2014-09-29 12:48:57 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-09-29 15:04:59 UTC
Created attachment 31925 [details] [review]
Bug 12927: Problems with item information tab on acq order from staged page

This patch fixes a regression introduced (by me)
on Bug 12673.

I adds the code needed to display properly all fields

To test:
1) Check that 'AcqCreateItem' syspref is set to 'placing an order'
2) Satage a file with some items
3) Go to a Vendor, create a basket, clic add from staged file, select your file
4) On 'Item information' tab fields are displayed wrong

5) Apply the patch

6) Reload, display must now be fixed

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-09-29 15:06:17 UTC
This patch fixes the described issue but the one raised on comment 12673 comment 11 is still valid.
Comment 6 Jonathan Druart 2014-09-29 15:09:40 UTC
(In reply to Jonathan Druart from comment #5)
> This patch fixes the described issue but the one raised on comment 12673
> comment 11 is still valid.

Forget that, it fixes exactly this issue. I mistook with another one.
Comment 7 Tomás Cohen Arazi 2014-10-16 15:53:36 UTC
Patch pushed to master.

Thanks Bernardo!
Comment 8 Jonathan Druart 2015-07-15 11:29:04 UTC
*** Bug 13008 has been marked as a duplicate of this bug. ***