Bug 12943 - Add patron branchcode to patron search results for holds
Summary: Add patron branchcode to patron search results for holds
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-17 14:46 UTC by Kyle M Hall (khall)
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 12943 - Add patron branchcode to patron search results for holds (1.51 KB, patch)
2014-09-17 14:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12943 - Add patron branchcode to patron search results for holds (1.59 KB, patch)
2014-09-20 18:36 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 12943 - Add patron branchcode to patron search results for holds (1.63 KB, patch)
2014-09-26 07:49 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2014-09-17 14:46:50 UTC
For some libraries, the current information specified in the patron results when search for a patron to place hold is insufficient. These libraries would like the branchcode to be added to the results to help identify the correct patron.
Comment 1 Kyle M Hall (khall) 2014-09-17 14:49:23 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall (khall) 2014-09-17 14:51:03 UTC
It should be noted that this patch brings the patron search results for holds in line with the patron search results for checkouts. In that sense, this could be considered a bug fix.
Comment 3 Nick Clemens (kidclamp) 2014-09-20 18:36:27 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-09-26 07:49:31 UTC
My first filling was to want the branchname instead of the branchcode. But this will add 1 DB request per result.
Comment 5 Jonathan Druart 2014-09-26 07:49:56 UTC
Created attachment 31888 [details] [review]
Bug 12943 - Add patron branchcode to patron search results for holds

For some libraries, the current information specified in the patron
results when search for a patron to place hold is insufficient. These
libraries would like the branchcode to be added to the results to help
identify the correct patron.

Test Plan:
1) Apply this patch
2) Browse to the holds for a record
3) Search for patrons from the record holds screen
4) Note the patron results now have the branchcode after the patron type

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Tomás Cohen Arazi (tcohen) 2014-11-21 19:02:49 UTC
Patch pushed to master.

Thanks Kyle!