Bug 12969 introduces a subroutine to centralize the VAT and price calculation. The basket page should use it.
Created attachment 31747 [details] [review] Bug 12970: Use the centralize VAT and prices calculation - basket.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basket.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Go on the basket page 4/ Apply the patch 5/ Verify you don't see any difference before and after applying the patch
Created attachment 31881 [details] [review] Bug 12970: Format totals The total values should be formated too. Test plan: 1/ Go on the basket page 2/ Using the CurrencyFormat, verify the totals are correctly formated.
Created attachment 31882 [details] [review] Bug 12970: Cancelled orders Previous patch does modify the code for cancelled orders. Test plan: Cancel 1+ orders and verify the prices are correct (i.e. the same as the non-cancelled orders) and that the prices are formated.
Created attachment 31954 [details] [review] Bug 12970: Use the centralize VAT and prices calculation - basket.pl I've applied the 3 patches against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2) Everything is OK. So I pass the patch to "Signed Off" status.
Created attachment 31955 [details] [review] Bug 12970: Format totals
Created attachment 31956 [details] [review] Bug 12970: Cancelled orders
Blocked by bug 12896 currently not applying. :(
*** Bug 12128 has been marked as a duplicate of this bug. ***
Created attachment 33572 [details] [review] Bug 12970: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer.
Created attachment 34964 [details] [review] [PASSED QA] Bug 12970: Use the centralize VAT and prices calculation - basket.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basket.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Go on the basket page 4/ Apply the patch 5/ Verify you don't see any difference before and after applying the patch Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 34965 [details] [review] [PASSED QA] Bug 12970: Format totals The total values should be formated too. Test plan: 1/ Go on the basket page 2/ Using the CurrencyFormat, verify the totals are correctly formated. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 34966 [details] [review] [PASSED QA] Bug 12970: Cancelled orders Previous patch does modify the code for cancelled orders. Test plan: Cancel 1+ orders and verify the prices are correct (i.e. the same as the non-cancelled orders) and that the prices are formated. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 34967 [details] [review] [PASSED QA] Bug 12970: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!
Tomas, this is *not* in master yet.
I'm sorry Jonathan. It is now pushed. I might have messed up some of my working branches at s ome point.