If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467.
Created attachment 31794 [details] [review] Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings
( SEARCH_RESULT.rating_total && SEARCH_RESULT.rating_total ) > 0 This is probably not what you intended to do. Do you mean: A && A>0 ?
Created attachment 32014 [details] [review] Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings (Fixed mistake with brackets, see comment #2)
Created attachment 32015 [details] [review] Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings (Fixed mistake with brackets, see comment #2) Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Works as advertized. Looks like you have to be logged in to trigger the error.
Created attachment 32021 [details] [review] Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings (Fixed mistake with brackets, see comment #2) Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Works as advertized. Looks like you have to be logged in to trigger the error. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Marc!