Bug 13036 - Exclude control columns from sorting on staff client catalog detail page
Summary: Exclude control columns from sorting on staff client catalog detail page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-07 13:36 UTC by Owen Leonard
Modified: 2015-06-04 23:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 13036 - Exclude control columns from sorting on staff client catalog detail page (4.42 KB, patch)
2014-10-07 13:49 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 13036 - Exclude control columns from sorting on staff client catalog detail page (4.43 KB, patch)
2014-10-26 02:16 UTC, Chris Cormack 		Details | Diff | Splinter Review
[PASSED QA] Bug 13036 - Exclude control columns from sorting on staff client catalog detail page (4.53 KB, patch)
2014-10-26 10:04 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-07 13:36:51 UTC 
On the catalog detail page the first column (of checkboxes) and the last column ("Edit") are sortable. They should be excluded from sorting because sorting them is useless.
Comment 1 Owen Leonard 2014-10-07 13:49:58 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-26 02:16:14 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-26 10:04:01 UTC 
Created attachment 32768 [details] [review]
[PASSED QA] Bug 13036 - Exclude control columns from sorting on staff client catalog detail page

The checkbox and "edit" column in the table of holdings on the
staff client detail page should be excluded from sorting since there is
no useful data to sort. This patch does so.

To test, view the detail page for a title which has multiple items.
Confirm that sorting works correctly.

Test under the following conditions:

 - with the StaffDetailItemSelection system preference enabled and
   disabled.
 - as users who do and do not have cataloging item edit privileges

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as desrcibed, no problems found.
Comment 4 Tomás Cohen Arazi (tcohen) 2014-11-21 22:54:26 UTC 
Patch pushed to master.

Thanks Owen!