Bug 13037 - Staff client cart should exclude articles when sorting by title
Summary: Staff client cart should exclude articles when sorting by title
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-07 13:58 UTC by Owen Leonard
Modified: 2015-06-04 23:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13037 - Staff client cart should exclude articles when sorting by title (3.13 KB, patch)
2014-10-07 14:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13037 - Staff client cart should exclude articles when sorting by title (3.15 KB, patch)
2014-10-14 14:19 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 13037 - Staff client cart should exclude articles when sorting by title (3.26 KB, patch)
2014-10-16 22:37 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-07 13:58:54 UTC
The staff client cart's table sorter is not configured to exclude articles when sorting by title.
Comment 1 Owen Leonard 2014-10-07 14:10:53 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-14 14:19:18 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-16 22:37:52 UTC
Created attachment 32473 [details] [review]
[PASSED QA] Bug 13037 - Staff client cart should exclude articles when sorting by title

This patch modifies the configuration of the staff client cart table
sorting to enable title sorting to ignore articles. Other column sorting
configuration settings are revised to use table header classes instead
of indexes.

To test, add multiple titles to the staff client cart, choosing several
titles which begin with articles ("a," "an," or "the" in English). View
the cart and test sorting of all columns. Sorting by title should sort
correctly while ignoring articles. Other columns should sort correctly
too.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script, works as described.
Comment 4 Tomás Cohen Arazi 2014-11-21 18:33:57 UTC
Patch pushed to master.

Thanks Owen!