Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page
Summary: Remove incorrect link to unused DataTables columnFilter plugin on staff clien...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-08 17:00 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page (1.53 KB, patch)
2014-10-08 17:51 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page (1.67 KB, patch)
2014-10-25 12:41 UTC, Frédéric Demians 		Details | Diff | Splinter Review
[PASSED QA] Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page (1.74 KB, patch)
2014-10-25 12:46 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-08 17:00:58 UTC 
The staff client search history page template links to jquery.dataTables.columnFilter.js, but the link is incorrect. The plugin is not used, so the link can be removed altogether.
Comment 1 Owen Leonard 2014-10-08 17:51:08 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2014-10-25 12:41:04 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-25 12:46:56 UTC 
Created attachment 32730 [details] [review]
[PASSED QA] Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page

The staff client search history page does not required the DataTables
columnFilter plugin, so the link (which pointed to the wrong location
anyway) can be removed.

To test, apply the patch and view your search history in the staff
client. Table sorter functions (sorting, paging, and searching) should
work correctly for current and previous sessions of catalog and
authority searches.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

This patch just affects the staff search history page which is still fully
functionnal after applying the patch.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2014-11-06 16:53:50 UTC 
Patch pushed to master.

Thanks Owen!