Bug 13050 - Follow-up for bug 12371 on self-registration verification notice
Summary: Follow-up for bug 12371 on self-registration verification notice
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-09 11:19 UTC by Marcel de Rooy
Modified: 2015-06-04 23:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13050: Follow-up for bug 12371 (2.58 KB, patch)
2014-10-09 11:23 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 13050: Follow-up for bug 12371 (2.60 KB, patch)
2014-10-26 02:06 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 13050: Follow-up for bug 12371 (2.75 KB, patch)
2014-10-26 10:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2014-10-09 11:19:59 UTC

    
Comment 1 Marcel de Rooy 2014-10-09 11:23:26 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-26 02:06:12 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-26 10:56:43 UTC
Created attachment 32772 [details] [review]
[PASSED QA] Bug 13050: Follow-up for bug 12371

This patch simplifies the SQL query in Letters.pm for table
borrower_modifications.
It also addresses the only case this query is used in opac-memberentry.
An unused variable in Letters.pm is removed.

Test plan:
Enable selfregistration on opac.
Set verification by email to required in prefs too.
Self-register two new users.
Check the email notices generated.
Verify the new users with the tokens in their notice.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Much cleaner SQL

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Cleaner and works as described, no regressions found.
Passes tests and QA script.
Comment 4 Tomás Cohen Arazi 2014-11-21 18:35:49 UTC
Patch pushed to master.

Thanks Marcel!